Skip to content

Fixing warn log message#3011

Merged
pongad merged 5 commits intogoogleapis:masterfrom
pgbhagat:master
Mar 11, 2018
Merged

Fixing warn log message#3011
pongad merged 5 commits intogoogleapis:masterfrom
pgbhagat:master

Conversation

@pgbhagat
Copy link
Copy Markdown

@pgbhagat pgbhagat commented Mar 8, 2018

Fixing warn log message

Fixing warn log message
@pgbhagat pgbhagat requested a review from pongad as a code owner March 8, 2018 12:05
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 8, 2018
@pgbhagat
Copy link
Copy Markdown
Author

pgbhagat commented Mar 8, 2018

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 8, 2018
Copy link
Copy Markdown
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Level.WARNING,
String.format(
"Ignoring Application Default Credentials: using explicit setting for API key instead.",
"Ignoring Application Default Credentials %s: using explicit setting for API key instead.",

This comment was marked as spam.

This comment was marked as spam.

logger.log(
Level.WARNING,
String.format(
"Ignoring Application Default Credentials: using explicit setting for API key instead.",

This comment was marked as spam.

@pongad
Copy link
Copy Markdown
Contributor

pongad commented Mar 9, 2018

@pgbhagat Gah, I'm sorry. The format string should have been {0}, not {}. I was thinking in Python. LGTM otherwise. I apologize for the churn.

@pgbhagat
Copy link
Copy Markdown
Author

pgbhagat commented Mar 9, 2018

No problem, i checked other files and it is used like {0}. Corrected in the next commit.

@pgbhagat
Copy link
Copy Markdown
Author

pgbhagat commented Mar 9, 2018

Is the AppVeyor build is failing because of
'Build execution time has reached the maximum allowed time for your plan (60 minutes).' ?

@pongad pongad merged commit a21cc36 into googleapis:master Mar 11, 2018
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…on image (#3011)

This PR moves `java.py` and the minimum required dependencies from
[synthtool](https://github.com/googleapis/synthtool/tree/master/synthtool).

It contains the changes of @JoeWang1127's
googleapis/synthtool@696c4bf

### Details of code transfer

Some files have been simplified and others simply verbatim-copied. Here
is a detailed list of changes (the paths are relative to
`library_generation/owlbot`:
* __`synthtool/__init__.py`__: No changes made. This is the module
initialization configuration to allow statements such as `import
synthtool as s` combined with `s.copy`, `s.replace`, etc. Without this,
we would have to use `import synthtool.transforms as s`.
* __`synthtool/_tracked_paths.py`__: No changes made. It allows to use
relative paths internally when working with library files.
* __`synthtool/gcp/common.py`__: Simplified to use java-only functions.
This file originally had a set of functions to support postprocessing of
languages written in multiple languages. The most important function is
`common_templates`, which renders the templates for the library (e.g.
workflow files, kokoro files). Note that `common_templates` was modified
in order to require and only allow specifying the path to the templates
via the `SYNTHTOOL_TEMPLATES` env var, as opposed to its original
support of 3 separate ways, including cloning synthtool and reading the
templates from there, because this is now an internal detail of how the
`library_generation` image will work.
* __`synthtool/gcp/samples.py`__: No changes made. This is a helper to
obtain path and metadata about the generated samples of a library. It is
then used [when rendering the
README](https://github.com/googleapis/sdk-platform-java/blob/4c5f932191dfb792b370c8446e8a018a9ef56ffb/library_generation/owlbot/templates/java_library/README.md?plain=1#L141-L150).
* __`synthtool/gcp/snippets.py`__: No changes made. Similar to
`samples.py` in the way it's
[used](https://github.com/googleapis/sdk-platform-java/blob/4c5f932191dfb792b370c8446e8a018a9ef56ffb/library_generation/owlbot/templates/java_library/README.md?plain=1#L68-L80)
to render a library's README
* __`synthool/languages/java.py`__: Small modifications around the fact
that we dropped several files (e.g. use `gcp.common.CommonTemplates`
instead of `gcp.CommonTemplates` to save us from an extra
`gcp/__init__.py`).
* __`synthtool/sources/templates.py`__: No changes made. Internally used
by `common_templates`. Contains the underlying usage of jinja2 to render
the templates.
* __`synthtool/transforms.py`__: No changes made. Contains a few
functions that are commonly used by `owlbot.py` files
([example](https://github.com/googleapis/java-bigtable/blob/45732201880a13eeced3d0332bd172aae0f73dbe/owlbot.py#L50))

### Changes in Dockerfile
We will not clone `synthtool` anymore. We will instead install it as a
separate package whose source code is within sdk-platform-java.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants