Move bom dependencies to outer pom#2976
Merged
pongad merged 6 commits intogoogleapis:masterfrom Mar 1, 2018
Merged
Conversation
Contributor
yihanzhen
commented
Feb 28, 2018
yihanzhen
commented
- Move guava, protobuf and test dependencies from bom/pom.xml to pom.xml
- Also fix: bigquery imported truth twice
also fixes: bigquery imported truth twice
googlebot
added
the
cla: yes
Contributor
Author
pongad
approved these changes
Feb 28, 2018
Contributor
|
I think we should do point 3 of #2781 (comment) as well, but that can be in a separate PR. |
Contributor
|
@garrettjonesgoogle Do you want to take a look? |
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-cloud-bigtable-v2</artifactId> | ||
| <version>${generated-proto-beta.version}</version> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
since they already exist in parent pom.xml
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
* test: fix ITDatabaseAdminTest failures * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * exclude owlbot pre-processor run on kokoro config * remove reduntant assert * fix test --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.