Skip to content

Bigtable: 07. Surface - ReadModifyWriteRow#2939

Merged
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
igorbernstein2:07-surface-readmodifywrite
Feb 28, 2018
Merged

Bigtable: 07. Surface - ReadModifyWriteRow#2939
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
igorbernstein2:07-surface-readmodifywrite

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

@igorbernstein2 igorbernstein2 commented Feb 22, 2018

@kevinsi4508, can you take a look when you have a moment?

This the last surface PR

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2018
@igorbernstein2 igorbernstein2 changed the title Bigtable: 08. Surface - ReadModifyWriteRow Bigtable: 07. Surface - ReadModifyWriteRow Feb 22, 2018
Copy link
Copy Markdown

@kevinsi4508 kevinsi4508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits
LGTM

* .increment("[FAMILY]", "[QUALIFIER]", 1)
* .append("[FAMILY2]", "[QUALIFIER2]", "suffix");
*
* boolean success = bigtableClient.readModifyWriteRowAsync(mutation);

This comment was marked as spam.

This comment was marked as spam.

* .increment("[FAMILY]", "[QUALIFIER]", 1)
* .append("[FAMILY2]", "[QUALIFIER2]", "suffix");
*
* boolean success = bigtableClient.readModifyWriteRowCallable().call(mutation);

This comment was marked as spam.

This comment was marked as spam.

builder.setRowKey(key);
}

public static ReadModifyWriteRow create(@Nonnull String tableId, @Nonnull String key) {

This comment was marked as spam.

This comment was marked as spam.

* a 64-bit big-endian signed integer), or the entire request will fail.
*/
public ReadModifyWriteRow increment(
@Nonnull String familyName, @Nonnull String qualifier, long amount) {

This comment was marked as spam.

This comment was marked as spam.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM after @kevinsi4508 's feedback is addressed

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

All feedback should be addressed

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

Please merge when ready

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

It looks like you'll need to resolve conflicts first.

@igorbernstein2 igorbernstein2 force-pushed the 07-surface-readmodifywrite branch from 455b3dc to 13ac4dc Compare February 28, 2018 18:55
@igorbernstein2
Copy link
Copy Markdown
Contributor Author

Rebased (also squashed to make rebasing easier)

@garrettjonesgoogle garrettjonesgoogle merged commit 54cd111 into googleapis:master Feb 28, 2018
@igorbernstein2
Copy link
Copy Markdown
Contributor Author

thank you!

@igorbernstein2 igorbernstein2 deleted the 07-surface-readmodifywrite branch March 1, 2018 02:07
suztomo pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…to v6.61.0 (#2939)

* chore(deps): update dependency com.google.cloud:google-cloud-spanner to v6.61.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
… the value in the json to be null rather than empty string (#2939)

Related to b/395940239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants