Skip to content

Add documentation to FakeStorageRpc and LocalStorageHelper#2906

Merged
yihanzhen merged 3 commits intogoogleapis:masterfrom
yihanzhen:storage-fakestoragerpc
Feb 21, 2018
Merged

Add documentation to FakeStorageRpc and LocalStorageHelper#2906
yihanzhen merged 3 commits intogoogleapis:masterfrom
yihanzhen:storage-fakestoragerpc

Conversation

@yihanzhen
Copy link
Copy Markdown
Contributor

@yihanzhen yihanzhen commented Feb 15, 2018

Document on method list(String bucket, Map options) since its behavior
is not implied but the method itself.
Fixes #2902

on method list(String bucket, Map options)
@yihanzhen yihanzhen requested a review from pongad as a code owner February 15, 2018 01:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2018

/**
* A bare-bones in-memory implementation of Storage, meant for testing.
* A bare-bones in-memory implementation of StorageRpc, meant for testing of CloudStorageFileSystem.

This comment was marked as spam.

@yihanzhen yihanzhen changed the title [WIP] Add documentation to FakeStorageRpc Add documentation to FakeStorageRpc Feb 20, 2018
@yihanzhen yihanzhen changed the title Add documentation to FakeStorageRpc Add documentation to FakeStorageRpc and LocalStorageHelper Feb 20, 2018
@yihanzhen
Copy link
Copy Markdown
Contributor Author

PTAL @pongad @garrettjonesgoogle

@pongad
Copy link
Copy Markdown
Contributor

pongad commented Feb 20, 2018

LGTM.

@yihanzhen yihanzhen merged commit 18bdfb6 into googleapis:master Feb 21, 2018
suztomo pushed a commit that referenced this pull request Mar 9, 2026
suztomo pushed a commit that referenced this pull request Mar 30, 2026
* Add documentation to FakeStorageRpc and LocalStorageHelper to reduce confusions
on method list(String bucket, Map options)
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
* Add documentation to FakeStorageRpc and LocalStorageHelper to reduce confusions
on method list(String bucket, Map options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants