Skip to content

core: make BaseWriteChannel surprise less#2900

Merged
pongad merged 2 commits intogoogleapis:masterfrom
pongad:wr-chan
Feb 14, 2018
Merged

core: make BaseWriteChannel surprise less#2900
pongad merged 2 commits intogoogleapis:masterfrom
pongad:wr-chan

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Feb 13, 2018

Fixes #2895. The chunk size should round up, not down.

Fixes #2896 by removing flush from capture. It is too surprising that
capture might fail.

Also adding @tswast since WriteChannel affects BigQuery.

Fixes #2895. The chunk size should round up, not down.

Fixes #2896 by removing flush from capture. It is too surprising that
capture might fail.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2018
Copy link
Copy Markdown
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 21e7f4c into googleapis:master Feb 14, 2018
@pongad pongad deleted the wr-chan branch February 14, 2018 22:00
suztomo pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…32.0 (#2900)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.31.0` -> `26.32.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:libraries-bom/26.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:libraries-bom/26.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:libraries-bom/26.31.0/26.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:libraries-bom/26.31.0/26.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-cloud-bom (com.google.cloud:libraries-bom)</summary>

### [`v26.32.0`](https://togithub.com/googleapis/java-cloud-bom/blob/HEAD/CHANGELOG.md#26320-2024-02-12)

[Compare Source](https://togithub.com/googleapis/java-cloud-bom/compare/v26.31.0...v26.32.0)

##### Dependencies

-   update actions/checkout action to v4 ([#&#8203;6401](https://togithub.com/googleapis/java-cloud-bom/issues/6401)) ([c4d5b2b](https://togithub.com/googleapis/java-cloud-bom/commit/c4d5b2b899d104444c2cb82c5c73f06010cf0ca0))
-   update actions/github-script action to v7 ([#&#8203;6402](https://togithub.com/googleapis/java-cloud-bom/issues/6402)) ([7441cf3](https://togithub.com/googleapis/java-cloud-bom/commit/7441cf3a5db3716378ba8c8917a3cde3c2af7157))
-   update dependency com.google.cloud:first-party-dependencies to v3.24.0 ([#&#8203;6408](https://togithub.com/googleapis/java-cloud-bom/issues/6408)) ([42a35bd](https://togithub.com/googleapis/java-cloud-bom/commit/42a35bdbd73a365626abcc852ea245bf54949f2f))
-   update dependency com.google.cloud:gapic-libraries-bom to v1.29.0 ([#&#8203;6425](https://togithub.com/googleapis/java-cloud-bom/issues/6425)) ([a0d6401](https://togithub.com/googleapis/java-cloud-bom/commit/a0d64014d5b646841aed6f50ae36c760ebe1797b))
-   update dependency com.google.cloud:google-cloud-bigquery to v2.37.1 ([#&#8203;6417](https://togithub.com/googleapis/java-cloud-bom/issues/6417)) ([5c3f811](https://togithub.com/googleapis/java-cloud-bom/commit/5c3f811dd6067a6ce40f392b00334eee941eb337))
-   update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v3.1.0 ([#&#8203;6414](https://togithub.com/googleapis/java-cloud-bom/issues/6414)) ([1e1c0d4](https://togithub.com/googleapis/java-cloud-bom/commit/1e1c0d431487b650b6ec4aa5568b072be4217821))
-   update dependency com.google.cloud:google-cloud-bigtable-bom to v2.33.0 ([#&#8203;6428](https://togithub.com/googleapis/java-cloud-bom/issues/6428)) ([f6e377b](https://togithub.com/googleapis/java-cloud-bom/commit/f6e377b65cd1959954161af06600034b5249a6c8))
-   update dependency com.google.cloud:google-cloud-datastore-bom to v2.18.3 ([#&#8203;6411](https://togithub.com/googleapis/java-cloud-bom/issues/6411)) ([6e7f9f9](https://togithub.com/googleapis/java-cloud-bom/commit/6e7f9f918697f00484d7311c7374acc50664510d))
-   update dependency com.google.cloud:google-cloud-firestore-bom to v3.16.3 ([#&#8203;6412](https://togithub.com/googleapis/java-cloud-bom/issues/6412)) ([b4a5db8](https://togithub.com/googleapis/java-cloud-bom/commit/b4a5db8826af199e135a14bce7922aaae5a5912a))
-   update dependency com.google.cloud:google-cloud-logging-bom to v3.15.17 ([#&#8203;6419](https://togithub.com/googleapis/java-cloud-bom/issues/6419)) ([589fea3](https://togithub.com/googleapis/java-cloud-bom/commit/589fea33cbb8621d4a82feb3699558ec66d50849))
-   update dependency com.google.cloud:google-cloud-logging-logback to v0.131.1-alpha ([#&#8203;6420](https://togithub.com/googleapis/java-cloud-bom/issues/6420)) ([f7c7fea](https://togithub.com/googleapis/java-cloud-bom/commit/f7c7fea78c26bdffd780e3ac5957de28b4edd7e8))
-   update dependency com.google.cloud:google-cloud-nio to v0.127.12 ([#&#8203;6422](https://togithub.com/googleapis/java-cloud-bom/issues/6422)) ([1659b1a](https://togithub.com/googleapis/java-cloud-bom/commit/1659b1a062d1d74374462da6a0d2a1ca7c0d0913))
-   update dependency com.google.cloud:google-cloud-pubsub-bom to v1.126.3 ([#&#8203;6421](https://togithub.com/googleapis/java-cloud-bom/issues/6421)) ([25fb563](https://togithub.com/googleapis/java-cloud-bom/commit/25fb5635e6d3ec629d8bf19cda23dcc0fd8f7662))
-   update dependency com.google.cloud:google-cloud-pubsub-bom to v1.126.4 ([#&#8203;6427](https://togithub.com/googleapis/java-cloud-bom/issues/6427)) ([b1c0c15](https://togithub.com/googleapis/java-cloud-bom/commit/b1c0c15d39491cb742ec2b25a3ca67d936a863fb))
-   update dependency com.google.cloud:google-cloud-pubsub-bom to v1.126.5 ([#&#8203;6429](https://togithub.com/googleapis/java-cloud-bom/issues/6429)) ([cd6553c](https://togithub.com/googleapis/java-cloud-bom/commit/cd6553cf80e85a7ffed9662b94cbdcdd50afda6e))
-   update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12.22 ([#&#8203;6426](https://togithub.com/googleapis/java-cloud-bom/issues/6426)) ([5b4bb70](https://togithub.com/googleapis/java-cloud-bom/commit/5b4bb70272659ad09180719a3e133e50de52eef0))
-   update dependency com.google.cloud:google-cloud-spanner-bom to v6.58.0 ([#&#8203;6423](https://togithub.com/googleapis/java-cloud-bom/issues/6423)) ([2e86546](https://togithub.com/googleapis/java-cloud-bom/commit/2e8654649d893f2462df5e2238fe4c390bca5183))
-   update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.15.3 ([#&#8203;6424](https://togithub.com/googleapis/java-cloud-bom/issues/6424)) ([5da843e](https://togithub.com/googleapis/java-cloud-bom/commit/5da843e33b394fbba4c8a2afacf2ce1d8553ddae))
-   update dependency com.google.cloud:google-cloud-storage-bom to v2.33.0 ([#&#8203;6418](https://togithub.com/googleapis/java-cloud-bom/issues/6418)) ([5e15c52](https://togithub.com/googleapis/java-cloud-bom/commit/5e15c525dcaf8af5e0814bbfb6feefad420014dd))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-spanner).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
#2900)

* chore: Update generation configuration at Wed Jan 29 02:19:49 UTC 2025

* chore: generate libraries at Wed Jan 29 02:20:26 UTC 2025

* chore: Update generation configuration at Thu Jan 30 02:19:10 UTC 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants