BigQuery lib. Add support for customer supplied encryptiion keys#2870
BigQuery lib. Add support for customer supplied encryptiion keys#2870pongad merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
|
I have integration tests for the change as well, but I don't have a good way to commit them. They require KMS key setup as dependency, it seems somewhat unreasonable to make everyone go through that setup if they want to run tests. The tests: |
| import static com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| import com.google.api.services.bigquery.model.JobConfigurationTableCopy; | ||
| import com.google.cloud.bigquery.LoadJobConfiguration.Builder; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1,99 @@ | |||
| /* | |||
| * Copyright 2016 Google LLC | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| import java.io.Serializable; | ||
| import java.util.Objects; | ||
|
|
||
| public final class EncryptionConfiguration implements Serializable { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| import com.google.cloud.bigquery.JobInfo.CreateDisposition; | ||
| import com.google.cloud.bigquery.JobInfo.WriteDisposition; | ||
| import com.google.cloud.bigquery.JobInfo.SchemaUpdateOption; | ||
| import com.google.cloud.bigquery.LoadJobConfiguration.Builder; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
One more comment but LGTM otherwise. @garrettjonesgoogle do you want to take a look?
| import java.io.Serializable; | ||
| import java.util.Objects; | ||
|
|
||
| public final class EncryptionConfiguration implements Serializable { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| import java.io.Serializable; | ||
| import java.util.Objects; | ||
|
|
||
| public final class EncryptionConfiguration implements Serializable { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Is there anything else I need to change before you can accept the request? |
#2870) * chore: Update generation configuration at Thu Feb 20 02:24:26 UTC 2025 * chore: Update generation configuration at Fri Feb 21 02:24:46 UTC 2025
#2870) * chore: Update generation configuration at Thu Feb 20 02:24:26 UTC 2025 * chore: Update generation configuration at Fri Feb 21 02:24:46 UTC 2025
3 participants
More details for this change in #2866