Skip to content

Fixing Logging integration tests#2860

Merged
garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom
garrettjonesgoogle:master
Feb 6, 2018
Merged

Fixing Logging integration tests#2860
garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle commented Feb 5, 2018

Fixes #2835

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2018
Thread.sleep(1000);
deleted = logging().deleteLog(logId);
}
assertTrue(deleted);

This comment was marked as spam.

@garrettjonesgoogle garrettjonesgoogle changed the title Adding rate limiting to Logging integration tests Fixing Logging integration tests Feb 5, 2018
@garrettjonesgoogle
Copy link
Copy Markdown
Contributor Author

It turns out the high quota usage was calls to ListLogMetrics and ListMonitoredResourceDescriptors. I fixed the first by clearing out the metrics in the Cloud Console. I fixed the second by bumping the page size from 1 to 100. The rate limiter is basically not necessary, so I removed it. I am retaining the retry on deletion, since that is regularly needed when I run the test locally.

PTAL

@garrettjonesgoogle garrettjonesgoogle merged commit f20eafc into googleapis:master Feb 6, 2018
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
#2860)

* chore: Update generation configuration at Tue Feb 11 02:24:11 UTC 2025

* chore: generate libraries at Tue Feb 11 02:24:47 UTC 2025
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
Statements that were executed using the Connection API and that were not
found in the statement cache (that is; it was the first time it was
executed), would not use the default query options that had been set for
the connection. This would mean that for example an optimizer version
that had been set for the connection would not be used the first time a
given query string would be executed using a connection. All subsequent
executions of the statement would use specified optimizer version.

This change ensures that both the first and all following executions of
the statement use the default query options that have been set.
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants