Skip to content

Bigtable: 00. Add a couple of developer helper scripts#2841

Merged
pongad merged 7 commits intogoogleapis:masterfrom
igorbernstein2:00-dev-scripts
Feb 5, 2018
Merged

Bigtable: 00. Add a couple of developer helper scripts#2841
pongad merged 7 commits intogoogleapis:masterfrom
igorbernstein2:00-dev-scripts

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

@igorbernstein2 igorbernstein2 commented Feb 2, 2018 •
edited
Loading

This is to ease updating the gapic client and updating googleapis

This has been reviewed by Kevin, however the following changes were made since:

  • paths have been updated from the overlay to the in tree updates
  • file lists have been added to allow regeneration
  • bin was renamed to scripts
  • a readme was added

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2018
@pongad
Copy link
Copy Markdown
Contributor

pongad commented Feb 5, 2018

LGTM. @garrettjonesgoogle Do you want to take a look?

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 5, 2018
View reviewed changes
Comment thread google-cloud-bigtable/pom.xml Outdated
<plugins>
<plugin>
<groupId>com.theoryinpractise</groupId>
<artifactId>googleformatter-maven-plugin</artifactId>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-bigtable/scripts/autogen_files.lst
@@ -0,0 +1,27 @@
src/test/java/com/google/cloud/bigtable/data/v2/MockBigtable.java

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-bigtable/scripts/regenerate.sh Outdated
# It is meant to be used to test changes to the gapic config before publishing
# To pull in upstream changes, please use update-deps.sh

set -eE # same as: `set -o errexit -o errtrace`

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-bigtable/scripts/regenerate.sh
@@ -0,0 +1,134 @@
#!/usr/bin/env bash

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-bigtable/scripts/update-deps.sh
git -C "$DIR" fetch origin >>$LOG 2>&1

log "Dropping uncommitted local changes"
git -C "$DIR" reset --hard HEAD >>$LOG 2>&1

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

igorbernstein2 commented Feb 5, 2018

Responded to all feedback. PTAL

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2
Copy link
Copy Markdown
Contributor Author

igorbernstein2 commented Feb 5, 2018

Created an issue:
#2852

Please merge when ready

@pongad pongad merged commit 6855f84 into googleapis:master Feb 5, 2018
@igorbernstein2 igorbernstein2 deleted the 00-dev-scripts branch February 20, 2018 17:06
@igorbernstein2 igorbernstein2 mentioned this pull request Feb 20, 2018
Closed
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@cloud-java-bot
chore: Update generation configuration at Tue Jan 28 18:27:51 UTC 2025 (
71d6c1a 
#2841)
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@release-please
chore(main): release 2.31.1 (#2841)
f8e3da7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@JoeWang1127
feat: generate pr description from configuration comparison result (#…
30acafa 
…2841)

In this PR:
- Generate pull request description from configuration comparison
result.
- The pull request description contains repo-level changes, if
applicable, and googleapis commit from baseline config (exclusive) to
current config (inclusive).

An example of pr description with repo-level change:
```
This pull request is generated with proto changes between [googleapis/googleapis@3b6f144](googleapis/googleapis@3b6f144) (exclusive) and [googleapis/googleapis@0cea717](googleapis/googleapis@0cea717) (inclusive).

BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
fix(deps): update the Java code generator (gapic-generator-java) to 1.2.3
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: update the libraries_bom version to 2.3.4
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Make Layout Parser generally available in V1

PiperOrigin-RevId: 638924855

Source Link: [googleapis/googleapis@0cea717](googleapis/googleapis@0cea717)
END_NESTED_COMMIT
END_COMMIT_OVERRIDE
```
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot @BenWhitehead
deps: update sdk-platform-java dependencies (#2841)
2de6b6c 
* deps: update sdk-platform-java dependencies

* chore: remove manually managed version of com.google.cloud.opentelemetry:exporter-metrics

* deps: update io.opentelemetry.semconv:opentelemetry-semconv to 1.27.0-alpha

---------

Co-authored-by: BenWhitehead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igorbernstein2 @pongad @garrettjonesgoogle @googlebot