Skip to content

use grpc-netty-shaded#2832

Merged
pongad merged 7 commits intogoogleapis:masterfrom
pongad:bump-grpc
Feb 7, 2018
Merged

use grpc-netty-shaded#2832
pongad merged 7 commits intogoogleapis:masterfrom
pongad:bump-grpc

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Feb 1, 2018 •
edited
Loading

Updates #2813 but does not close, since Spanner still requires unshaded netty.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2018
pongad
pongad commented Feb 1, 2018
View reviewed changes
Comment thread google-cloud-bom/pom.xml Outdated
<gax-httpjson.version>0.34.0</gax-httpjson.version>
<gax.version>1.17.1-SNAPSHOT</gax.version>
<gax-grpc.version>1.17.1-SNAPSHOT</gax-grpc.version>
<gax-httpjson.version>0.34.1-SNAPSHOT</gax-httpjson.version>

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated
.maxHeaderListSize(MAX_HEADER_LIST_SIZE)
.maxMessageSize(MAX_MESSAGE_SIZE);
// .maxHeaderListSize(MAX_HEADER_LIST_SIZE)
.maxInboundMessageSize(MAX_MESSAGE_SIZE);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-util/google-cloud-compat-checker/pom.xml Outdated
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative-boringssl-static</artifactId>
<version>2.0.7.Final</version>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad pongad mentioned this pull request Feb 2, 2018
Closed
@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Feb 2, 2018

@garrettjonesgoogle PTAL
@vkedia Spanner is no longer affected.

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 2, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and of course, don't merge until the gax dependency is not a snapshot version)

@pongad pongad mentioned this pull request Feb 5, 2018
Closed
@pongad pongad changed the title DO NOT SUBMIT: use grpc-netty-shaded use grpc-netty-shaded Feb 6, 2018
@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Feb 6, 2018

@garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle approved these changes Feb 6, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-LGTM

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Feb 7, 2018

@garrettjonesgoogle PTAL. Changed Spanner like we talked about

garrettjonesgoogle
garrettjonesgoogle approved these changes Feb 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-LGTM

@pongad pongad merged commit e4fdfad into googleapis:master Feb 7, 2018
@pongad pongad deleted the bump-grpc branch February 7, 2018 00:52
@amerpersonal
Copy link
Copy Markdown

amerpersonal commented May 17, 2018

Any progress on this? Shading somehow won't work for me. I'm using ScalaPB in SBT project. This issue is really frustrating

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented May 21, 2018

@amerpersonal The PR has already merged. Could you open a separate issue with the problem you have?

chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@cloud-java-bot
chore: Update generation configuration at Sat Jan 18 02:19:00 UTC 2025 (
a855aed 
#2832)
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@release-please @cloud-java-bot
chore(main): release 2.46.0 (#2832)
9d7371d 
* chore(main): release 2.46.0

* chore: generate libraries at Fri Dec 13 00:04:04 UTC 2024

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreamlin andreamlin Awaiting requested review from andreamlin

@vkedia vkedia Awaiting requested review from vkedia

2 more reviewers

@ejona86 ejona86 ejona86 left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pongad @amerpersonal @ejona86 @garrettjonesgoogle @vkedia @googlebot