Skip to content

logback: log stack trace#2765

Merged
pongad merged 3 commits intogoogleapis:masterfrom
pongad:logging-ex
Jan 22, 2018
Merged

logback: log stack trace#2765
pongad merged 3 commits intogoogleapis:masterfrom
pongad:logging-ex

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Jan 11, 2018

Fixes #2735.

@pongad pongad requested a review from jabubake January 11, 2018 00:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
jabubake
jabubake reviewed Jan 11, 2018
View reviewed changes
Comment thread ...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
private LogEntry logEntryFor(ILoggingEvent e) {
String payload = e.getFormattedMessage();
StringBuilder payload = new StringBuilder(e.getFormattedMessage());
for (StackTraceElement stackEl : e.getCallerData()) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

jabubake
jabubake previously approved these changes Jan 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jabubake jabubake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 11, 2018
View reviewed changes
Comment thread ...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
private LogEntry logEntryFor(ILoggingEvent e) {
String payload = e.getFormattedMessage();
StringBuilder payload = new StringBuilder(e.getFormattedMessage());
for (StackTraceElement stackEl : e.getCallerData()) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jan 12, 2018

@jabubake I'm sorry. Looking at this closer, I don't think this is right. The getCallerData returns the trace of the running thread, not of the exception. I don't see a way to get exception trace out of ILoggingEvent. Can you advise?

@jabubake
Copy link
Copy Markdown
Contributor

jabubake commented Jan 12, 2018

ILoggingEvent has a getThrowableProxy method.
see examples here : http://www.javased.com/?api=ch.qos.logback.classic.spi.IThrowableProxy

@jabubake jabubake dismissed their stale review January 12, 2018 16:27

does not log exception as expected

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jan 15, 2018

@garrettjonesgoogle @jabubake PTAL. I think this actually works now :)

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jan 19, 2018

@garrettjonesgoogle @jabubake Ping

garrettjonesgoogle
garrettjonesgoogle approved these changes Jan 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestion

Comment thread ...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
return builder.build();
}

@InternalApi

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread ...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java
.append(": ")
.append(throwProxy.getMessage())
.append('\n');
StackTraceElementProxy[] trace = throwProxy.getStackTraceElementProxyArray();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad pongad merged commit 4ca5d56 into googleapis:master Jan 22, 2018
@pongad pongad deleted the logging-ex branch January 22, 2018 00:25
@glindstedt glindstedt mentioned this pull request Jan 29, 2018
Closed
@skjolber skjolber mentioned this pull request Mar 13, 2018
Closed
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@pongad
logback: log stack trace (#2765)
b820bf1 
Fixes #2735.
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@cloud-java-bot
chore: Update generation configuration at Wed Nov 13 02:24:27 UTC 2024 (
d9f7029 
#2765)

* chore: Update generation configuration at Tue Nov 12 02:22:37 UTC 2024

* chore: generate libraries at Tue Nov 12 02:23:19 UTC 2024

* chore: Update generation configuration at Wed Nov 13 02:24:27 UTC 2024
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@pongad
logback: log stack trace (googleapis#2765)
36a03e1 
Fixes googleapis#2735.
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@BenWhitehead
fix: update gRPC ReadObject retry to avoid double retry (#2765)
b997288 
Prevent adding an unavailable error to the queue if the retrying loop is still active.

Also, cleanup unused retry config for gRPC ReadObject.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

@jabubake jabubake jabubake left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @jabubake @garrettjonesgoogle @googlebot