Skip to content

Refactor#2754

Closed
ashutoshcp wants to merge 2 commits intogoogleapis:masterfrom
ashutoshcp:master
Closed

Refactor#2754
ashutoshcp wants to merge 2 commits intogoogleapis:masterfrom
ashutoshcp:master

Conversation

@ashutoshcp
Copy link
Copy Markdown

@ashutoshcp ashutoshcp commented Jan 6, 2018

  1. typo fix
  2. made values as variable
  3. used simpler method for string concat
  4. assert, so that NPE can be avoided

@ashutoshcp
1. typo fix
d734f13 
2. made values as variable
3. used simpler method for string concat
4. assert, so that NPE can be avoided
@googlebot
Copy link
Copy Markdown

googlebot commented Jan 6, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 6, 2018
@ashutoshcp
Copy link
Copy Markdown
Author

ashutoshcp commented Jan 6, 2018

I signed it!

@googlebot
Copy link
Copy Markdown

googlebot commented Jan 6, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 6, 2018
@pongad
Copy link
Copy Markdown
Contributor

pongad commented Jan 29, 2018 •
edited
Loading

@ashu01 This seems to fail RemoteBigQueryHelperTest. I think this PR changes maxRetryDelay from 30 to 60 seconds. Could you edit this?

For context, retry delay is the amount to time to sleep between retries, so it's not the same as connection time out.

The rest of the PR looks good to me. @garrettjonesgoogle PTAL.

@ashutoshcp
Copy link
Copy Markdown
Author

ashutoshcp commented Jan 29, 2018 via email

@ashutoshcp ashutoshcp closed this Jan 29, 2018
@ashutoshcp ashutoshcp mentioned this pull request Jan 29, 2018
Merged
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@JoeWang1127
chore: use Junit5 in java core (#2754)
eadcb32 
Fix #2726.

`BaseSerializationTest` will not migrate to Junit 5 because downstream
libraries, e.g., java-logging, are extending this class and these
libraries still use Junit 4. Migrating this class to Junit 5 will cause
test failures in downstream libraries.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@harshachinta @gcf-owl-bot
feat: update OwlBot.yaml file to pull autogenerated executor code (#2754
1093ba7 
)

* feat: update OwlBot.yaml file to pull autogenerated executor code

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 6.56.0 (#2755)
405a634 
🤖 I have created a release *beep* *boop*
---


## [6.56.0](https://togithub.com/googleapis/java-spanner/compare/v6.55.0...v6.56.0) (2024-01-05)


### Features

* Add autoscaling config in the instance to support autoscaling in systests ([#2756](https://togithub.com/googleapis/java-spanner/issues/2756)) ([b0c36b5](https://togithub.com/googleapis/java-spanner/commit/b0c36b5148379f5debaf802aed3b0cca723b0a27))
* Add support for Directed Read options ([#2766](https://togithub.com/googleapis/java-spanner/issues/2766)) ([e97d4da](https://togithub.com/googleapis/java-spanner/commit/e97d4dac279b22760290e0aa4bc4816212b9ab31))
* Update OwlBot.yaml file to pull autogenerated executor code ([#2754](https://togithub.com/googleapis/java-spanner/issues/2754)) ([1093ba7](https://togithub.com/googleapis/java-spanner/commit/1093ba77658b3a592dd184284a324c0eea272851))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.21.0 ([#2772](https://togithub.com/googleapis/java-spanner/issues/2772)) ([8616fcf](https://togithub.com/googleapis/java-spanner/commit/8616fcf3c58d042520ed0dd2e6fb37cf3a9654cc))


### Documentation

* Samples and tests for auto-generated createDatabase and createInstance APIs. ([#2764](https://togithub.com/googleapis/java-spanner/issues/2764)) ([36837a4](https://togithub.com/googleapis/java-spanner/commit/36837a49b3b6e8401e956cb92f565af3fcc3e1a2))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@JesseLovelace
docs: add samples for soft delete (objects) (#2754)
17e90e5 
* feat: add samples for soft delete (objects)

* seperate calls; run lint

* style issues

* one more lint issue

* fix test issue

* create test-specific bucket in restore test

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashutoshcp @googlebot @pongad