bigquery: add setUseLegacySql to ViewDefinition#2743
Merged
pongad merged 1 commit intogoogleapis:masterfrom Jan 4, 2018
pongad:bq-legacy
Merged
bigquery: add setUseLegacySql to ViewDefinition#2743pongad merged 1 commit intogoogleapis:masterfrom pongad:bq-legacy
pongad merged 1 commit intogoogleapis:masterfrom
pongad:bq-legacy
Conversation
googlebot
added
the
cla: yes
Contributor
|
The test failure seems to be a problem loading plugins. |
tswast
approved these changes
Jan 3, 2018
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
LGTM.
I notice you don't attempt to override the server default. That definitely keeps things simpler, but I do believe there was a requirement to make standard SQL the default. Do you want to follow-up with a PR to do that?
Contributor
Author
|
SGTM. I made #2748 so I don't forget. |
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
This is to unblock protocol buffer version updates.
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2720.