logging: flowcontrol should block#2741
Merged
pongad merged 2 commits intogoogleapis:masterfrom Jan 6, 2018
pongad:logging-block
Merged
logging: flowcontrol should block#2741pongad merged 2 commits intogoogleapis:masterfrom pongad:logging-block
pongad merged 2 commits intogoogleapis:masterfrom
pongad:logging-block
Conversation
googlebot
added
the
cla: yes
| .setMaxOutstandingRequestBytes(10485760L) | ||
| .setLimitExceededBehavior(LimitExceededBehavior.Block) | ||
| .build()) | ||
| .build()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@garrettjonesgoogle PTAL |
Contributor
|
LGTM |
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
#2741) * chore: Update generation configuration at Sat Oct 26 02:22:52 UTC 2024 * chore: Update generation configuration at Sun Oct 27 02:27:42 UTC 2024
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
…ryconnection-v1 to v2.21.0 (#2741)
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
#2741) If a read is opened without a generation, we want to ensure we restart for the same generation. We have this behavior for json This is mainly to avoid a race condition of reading an object (gen=1), that object being replaced (gen=2) then retry attempts to read it again we need to read gen=1 otherwise we will return corrupted data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2714.