Skip to content

pubsub: make connection log less aggressively#2615

Merged
pongad merged 2 commits intogoogleapis:masterfrom
pongad:log-less
Nov 13, 2017
Merged

pubsub: make connection log less aggressively#2615
pongad merged 2 commits intogoogleapis:masterfrom
pongad:log-less

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Nov 13, 2017

Fixes #2614

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2017
logger.log(Level.WARNING, "failed to send acks", e);
if (isAlive()) {
logger.log(Level.WARNING, "failed to send ack operations", e);
}

This comment was marked as spam.

This comment was marked as spam.

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Nov 13, 2017

@garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM

@pongad pongad merged commit 4a5156a into googleapis:master Nov 13, 2017
@pongad pongad deleted the log-less branch November 13, 2017 06:25
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigquerystorage/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
In this PR:
- Remove generated files after running tests.

Note that files generated by `docker run` have root permission, thus
can't be removed by this PR. This issue will be resolved in #2615.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
#2615)

## Context
[Milestone 7 of Hermetic
Build](https://docs.google.com/document/d/1v-sJBmdNEVBRryL8n90XK8OIiqVphaJemXVhANw14Jk/edit?pli=1&resourcekey=0-QGUb2do-JBlDWKvptWBp_g&tab=t.0#bookmark=id.bkbj04ib2d4n)

## In this PR
- Bake synthtool into the docker image (we won't `git clone` it anymore)
- Bake the owlbot CLI into the docker image (we won't use docker inside
docker anymore)
- Create a DEVELOPMENT.md file with instructions for local setup
(example: install owlbot CLI locally)

## Follow ups
- [ ] modify google-cloud-java's workflows to correct the volume mapping
being used

---------

Co-authored-by: Joe Wang <[email protected]>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
meltsufin pushed a commit that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants