Adds support for attaching labels to cloud spanner sessions by vkedia · Pull Request #2606 · googleapis/google-cloud-java

vkedia · 2017-11-09T19:39:57Z

No description provided.

googlebot · 2017-11-09T19:40:00Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

vkedia · 2017-11-09T19:41:30Z

cc @tomayles

Sign in to view


+    /**
+     * Sets the labels to add to all Sessions created in this client. 
+     */


Sign in to view

  }

+  public Map<String, String> getSessionLabels() {
+	  return sessionLabels;


Author: Vikas Kedia <[email protected]>

…into session-labels

vam-google

LGTM (with few comments)

Sign in to view

+     *     <a href="https://cloud.google.com/spanner/docs/reference/rpc/google.spanner.v1#google.spanner.v1.Session">
+     *     api docs </a>.
+     */
+    public Builder setSessionLabels(Map<String, String> sessionLabels) {


Sign in to view

+    CreateSessionRequest.Builder request =
+        CreateSessionRequest.newBuilder().setDatabase(databaseName);
+    if (labels != null && !labels.isEmpty()) {
+    	  Session.Builder session = Session.newBuilder().putAllLabels(labels);


vkedia · 2017-11-14T18:41:16Z

@tomayles Does this look good?

Sign in to view


+    /**
+     * Sets the labels to add to all Sessions created in this client.
+     * 


…2606) Now we will record open telemetry metrics only if explicitly turned on.

…PACE (#2606) PiperOrigin-RevId: 624989428 Source-Link: googleapis/googleapis@caf600a Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc580b8ea4c07f774093d0f8c4afedd2eae6e856 Copy-Tag: eyJwIjoiamF2YS1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJjYzU4MGI4ZWE0YzA3Zjc3NDA5M2QwZjhjNGFmZWRkMmVhZTZlODU2In0= build: Update protobuf to 25.3 in WORKSPACE PiperOrigin-RevId: 624989428 Source-Link: googleapis/googleapis@caf600a Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc580b8ea4c07f774093d0f8c4afedd2eae6e856 Copy-Tag: eyJwIjoiamF2YS1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJjYzU4MGI4ZWE0YzA3Zjc3NDA5M2QwZjhjNGFmZWRkMmVhZTZlODU2In0= docs:card proto update feat: material icon in card PiperOrigin-RevId: 624942359 Source-Link: googleapis/googleapis@436a34a Source-Link: https://github.com/googleapis/googleapis-gen/commit/7c861248a2ab2c3dbd25d52afec49ff905e66a8b Copy-Tag: eyJwIjoiamF2YS1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiI3Yzg2MTI0OGEyYWIyYzNkYmQyNWQ1MmFmZWM0OWZmOTA1ZTY2YThiIn0= feat: Add DEMAND_GEN_ADS and DEMAND_GEN_ADS_DISCOVER_SURFACE in ReportingContextEnum docs: Deprecate DISCOVERY_ADS and document the new enum values PiperOrigin-RevId: 619534137 Source-Link: googleapis/googleapis@b4771b1 Source-Link: https://github.com/googleapis/googleapis-gen/commit/bd9798abf4dd809911e31ec7c2174f9817c72c69 Copy-Tag: eyJwIjoiamF2YS1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJiZDk3OThhYmY0ZGQ4MDk5MTFlMzFlYzdjMjE3NGY5ODE3YzcyYzY5In0= --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <[email protected]> Co-authored-by: Tomo Suzuki <[email protected]> Co-authored-by: Tomo Suzuki <[email protected]>

#2606) * chore: Update generation configuration at Wed Oct 29 02:36:04 UTC 2025 * chore: generate libraries at Wed Oct 29 02:36:40 UTC 2025 * chore: Update generation configuration at Thu Oct 30 02:35:08 UTC 2025 * chore: Update generation configuration at Fri Oct 31 02:36:01 UTC 2025 * chore: Update generation configuration at Sat Nov 1 02:35:35 UTC 2025 * chore: Update generation configuration at Tue Nov 4 02:36:23 UTC 2025 * chore: Update generation configuration at Wed Nov 5 02:35:14 UTC 2025 * chore: generate libraries at Wed Nov 5 02:35:46 UTC 2025 * chore: Update generation configuration at Thu Nov 6 02:35:50 UTC 2025 * chore: Update generation configuration at Fri Nov 7 02:34:52 UTC 2025 * chore: Update generation configuration at Sat Nov 8 02:31:55 UTC 2025 * chore: generate libraries at Sat Nov 8 02:32:23 UTC 2025 * chore: Update generation configuration at Tue Nov 11 02:35:53 UTC 2025 * chore: Update generation configuration at Wed Nov 12 02:34:52 UTC 2025 * chore: Update generation configuration at Thu Nov 13 02:35:52 UTC 2025 --------- Co-authored-by: Diego Marquez <[email protected]>

Adds support for attaching labels to cloud spanner sessions

4714adc

vkedia requested a review from vam-google November 9, 2017 19:39

vkedia requested a review from garrettjonesgoogle as a code owner November 9, 2017 19:39

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 9, 2017

tomayles reviewed Nov 9, 2017

View reviewed changes

garrettjonesgoogle reviewed Nov 9, 2017

View reviewed changes

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated

}

public Map<String, String> getSessionLabels() {

return sessionLabels;

This comment was marked as spam.

Sign in to view

Vikas Kedia and others added 4 commits November 9, 2017 13:11

Fixed style issues

919c934

Fixed style issues

5364ae0

Author: Vikas Kedia <[email protected]>

Merge branch 'session-labels' of github.com:vkedia/google-cloud-java …

819af21

…into session-labels

Few more style fixes and null check

c534152

vam-google approved these changes Nov 10, 2017

View reviewed changes

Adds tests for NPE

0a639fe

vkedia mentioned this pull request Nov 10, 2017

Updated Spanner features googleapis/google-cloud-ruby#1817

Closed

tomayles reviewed Nov 14, 2017

View reviewed changes

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

/**

* Sets the labels to add to all Sessions created in this client.

*

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tomayles approved these changes Nov 14, 2017

View reviewed changes

Doc fix

0bec2b4

vkedia added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 18, 2017

vkedia merged commit 6c8c37c into googleapis:master Nov 18, 2017

chingor13 pushed a commit that referenced this pull request Feb 20, 2026

chore: move open telemetry instrumentation to separate source file (#…

3e681bd

…2606) Now we will record open telemetry metrics only if explicitly turned on.

Conversation

vkedia commented Nov 9, 2017

Uh oh!

googlebot commented Nov 9, 2017

Uh oh!

vkedia commented Nov 9, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

vkedia commented Nov 14, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants