pubsub: add keepalive#2585
Merged
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom Nov 7, 2017
pongad:pubsub-idle
Merged
pubsub: add keepalive#2585garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom pongad:pubsub-idle
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
pongad:pubsub-idle
Conversation
If streaming pull connection is idle for a long time, a firewall/proxy might terminate the connection. The keepalive should prevent this from happening, or at least let us notice that the connection is terminated so we don't wait forever. Fixes #2506
googlebot
added
the
cla: yes
Contributor
Author
|
We seem to be getting some deadlock in CI. Analysis and experience suggest these flakes are caused by the test themselves; the libraries aren't doing anything fundamentally wrong. I'm planning to simply pubsub implementation and tests in upcoming weeks which, I hope, will make these flakes go away. I think we can merge this for now. |
garrettjonesgoogle
approved these changes
Nov 7, 2017
schmidt-sebastian
pushed a commit
to FirebasePrivate/google-cloud-java
that referenced
this pull request
Nov 9, 2017
If streaming pull connection is idle for a long time, a firewall/proxy might terminate the connection. The keepalive should prevent this from happening, or at least let us notice that the connection is terminated so we don't wait forever. Fixes googleapis#2506
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
…41.0 (#2585) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.41.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If streaming pull connection is idle for a long time,
a firewall/proxy might terminate the connection.
The keepalive should prevent this from happening,
or at least let us notice that the connection is terminated so we don't
wait forever.
Fixes #2506