Using commitTime instead of updateTime for deletes#2493
Merged
pongad merged 1 commit intogoogleapis:masterfrom Oct 10, 2017
Merged
Using commitTime instead of updateTime for deletes#2493pongad merged 1 commit intogoogleapis:masterfrom
pongad merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
schmidt-sebastian
added a commit
to FirebasePrivate/google-cloud-java
that referenced
this pull request
Nov 9, 2017
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
* chore: update copyright year for auto-generated protos PiperOrigin-RevId: 631538781 Source-Link: googleapis/googleapis@3597f7d Source-Link: https://github.com/googleapis/googleapis-gen/commit/8021fdf8d66f6005519c044d5834124b677dc919 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
…-quantum aligned write calls (#2493) Despite GCS only allowing incremental updates to a resumable session at 256KiB byte boundaries, we have observed an extremely rare case of an incremental write being non-quantum aligned. The change in this PR makes ApiaryUnbufferedWritableByteChannel graceful to this possibility, and will only set the finalization header when close is invoked. If a write is not quantum aligned, it will either: 1) not be consumed at all, at which point write can be called again with the still enqueued bytes 2) partially consumed, with the position of the provided ByteBuffers updated to reflect how much of their bytes were consumed, matching up with the number of bytes actually consumed returned from `write()` Add new integration test to intentionally perform non-quantum aligned `write()` calls to ApiaryUnbufferedWritableByteChannel. Separate change to gRPC affected code path to come in a later PR. b/330550326
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
🤖 I have created a release *beep* *boop* --- ## [1.141.1](https://togithub.com/googleapis/java-pubsub/compare/v1.141.0...v1.141.1) (2025-07-28) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.60.2 ([7afae21](https://togithub.com/googleapis/java-pubsub/commit/7afae21e5e3df16742646363ca199ec14c42bc21)) * Remove element_count_limit and request_byte_limit from pubsub_gapic.yaml ([7afae21](https://togithub.com/googleapis/java-pubsub/commit/7afae21e5e3df16742646363ca199ec14c42bc21)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.53.0 ([#2489](https://togithub.com/googleapis/java-pubsub/issues/2489)) ([5a454b9](https://togithub.com/googleapis/java-pubsub/commit/5a454b9c36419dcfaf79edb1ec1d066b20836f87)) * Update dependency com.google.cloud:google-cloud-core to v2.58.2 ([#2493](https://togithub.com/googleapis/java-pubsub/issues/2493)) ([9a1c17e](https://togithub.com/googleapis/java-pubsub/commit/9a1c17e50e5fc9a807532d289a7f6e8b5d412f59)) * Update dependency com.google.cloud:google-cloud-storage to v2.53.3 ([#2486](https://togithub.com/googleapis/java-pubsub/issues/2486)) ([9416cc9](https://togithub.com/googleapis/java-pubsub/commit/9416cc99f826b80412b0e5eba0068a35b82390c6)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.50.2 ([#2494](https://togithub.com/googleapis/java-pubsub/issues/2494)) ([9f73ef0](https://togithub.com/googleapis/java-pubsub/commit/9f73ef0dcaabb4a536741336eb6cfc6601b75f65)) * Update dependency org.xerial.snappy:snappy-java to v1.1.10.8 ([#2492](https://togithub.com/googleapis/java-pubsub/issues/2492)) ([a55e214](https://togithub.com/googleapis/java-pubsub/commit/a55e214ffad8371eb82a1d49b8b1eadcacf15392)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
🤖 I have created a release *beep* *boop* --- ## [1.141.1](https://togithub.com/googleapis/java-pubsub/compare/v1.141.0...v1.141.1) (2025-07-28) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.60.2 ([bbc4e3c](https://togithub.com/googleapis/java-pubsub/commit/bbc4e3cd43d8d3f6bada03bbd1617f1ab930de9b)) * Remove element_count_limit and request_byte_limit from pubsub_gapic.yaml ([bbc4e3c](https://togithub.com/googleapis/java-pubsub/commit/bbc4e3cd43d8d3f6bada03bbd1617f1ab930de9b)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.53.0 ([#2489](https://togithub.com/googleapis/java-pubsub/issues/2489)) ([106b9eb](https://togithub.com/googleapis/java-pubsub/commit/106b9ebc80808837b397ef18be4767c224e0c44e)) * Update dependency com.google.cloud:google-cloud-core to v2.58.2 ([#2493](https://togithub.com/googleapis/java-pubsub/issues/2493)) ([5f77e62](https://togithub.com/googleapis/java-pubsub/commit/5f77e622c4651b09a79a1ee8f7965216a2a96d33)) * Update dependency com.google.cloud:google-cloud-storage to v2.53.3 ([#2486](https://togithub.com/googleapis/java-pubsub/issues/2486)) ([d4611c0](https://togithub.com/googleapis/java-pubsub/commit/d4611c0dd7490ffe14f01f2e5a2ede9ede38be12)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.50.2 ([#2494](https://togithub.com/googleapis/java-pubsub/issues/2494)) ([f13c058](https://togithub.com/googleapis/java-pubsub/commit/f13c058b7c55217163580ccd12869aa78e826413)) * Update dependency org.xerial.snappy:snappy-java to v1.1.10.8 ([#2492](https://togithub.com/googleapis/java-pubsub/issues/2492)) ([1139c0b](https://togithub.com/googleapis/java-pubsub/commit/1139c0b28cb5dad99696f7f1722ddb3e42055037)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we use 1/1/1970 as our update time for deletes (https://b.corp.google.com/issues/65212850). This uses the commit time instead - as we do in Node.