Skip to content

Fix requester pays issues: #2392, #2391 and #2439.#2464

Merged
vam-google merged 2 commits intogoogleapis:masterfrom
vam-google:requester_pays
Sep 27, 2017
Merged

Fix requester pays issues: #2392, #2391 and #2439.#2464
vam-google merged 2 commits intogoogleapis:masterfrom
vam-google:requester_pays

Conversation

@vam-google
Copy link
Copy Markdown
Contributor

@vam-google vam-google commented Sep 26, 2017 •
edited
Loading

Fixes for #2392, #2391 and #2439

To get requesterPays info on a bucket:

Bucket bucket = storage.get(bucketName, Storage.BucketGetOption.fields(BucketField.BILLING));

To download a bucket

blob.downloadTo(destFilePath, Blob.BlobSourceOption.userProject(projectId));

or directly use Blob.reader(BlobSourceOption... options) method.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2017
@jabubake
Copy link
Copy Markdown
Contributor

jabubake commented Sep 26, 2017

https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-storage/src/test/java/com/google/cloud/storage/BucketTest.java#L696 seems wrong
Also, given this change, can you update
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/82fa63d01fe19b5158f258f2a2991378e074ab0f/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java#L1507
to use the BILLING field and assert that requesterPays is false.

@vam-google
Copy link
Copy Markdown
Contributor Author

vam-google commented Sep 26, 2017 •
edited
Loading

Fixed the BucketTest, left ITStorageTest untouched as we discussed.
Note, requesterPays() will still return null if it is set to null on server (i.e. even if we request a bucket with BucketField.BILLING option specified, but on server it is set to null, the client will return null, not false) . In such cases null essentially has same meaning as false, but client still returns null to stay consistent and provide accurate information about data returned from server.

@vam-google
Copy link
Copy Markdown
Contributor Author

vam-google commented Sep 26, 2017

PTAL

@jabubake
Copy link
Copy Markdown
Contributor

jabubake commented Sep 26, 2017

LGTM

@vam-google vam-google merged commit 8f77925 into googleapis:master Sep 27, 2017
@frankyn
Copy link
Copy Markdown
Contributor

frankyn commented Sep 27, 2017

Thanks for picking this up! +1 LGTM.

chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@alicejli @gcf-owl-bot
chore: include recommended_package in repo-metadata.json (#2464)
af43c20 
* chore: include recommended_package in repo-metadata.json

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
deps: update googleapis/sdk-platform-java action to v2.60.0 (#2464)
7a0af37
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
deps: update googleapis/sdk-platform-java action to v2.60.0 (#2464)
edf387a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

@jabubake jabubake Awaiting requested review from jabubake

@frankyn frankyn Awaiting requested review from frankyn

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vam-google @jabubake @frankyn @googlebot