Skip to content

pubsub: correct emulator sample#2254

Merged
pongad merged 1 commit intogoogleapis:masterfrom
pongad:pub-sub-emu-doc
Jul 19, 2017
Merged

pubsub: correct emulator sample#2254
pongad merged 1 commit intogoogleapis:masterfrom
pongad:pub-sub-emu-doc

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Jul 19, 2017

Previously we use TopicAdminSettings.defaultBuilder().
The default channel uses secure connection,
which is incompatible with the emulator.
This commit corrects this.

We cannot yet provide a way for users to set plain text
in InstantiatingChannelProvider, since usePlaintext
is still a beta API.

Previously we use TopicAdminSettings.defaultBuilder().
The default channel uses secure connection,
which is incompatible with the emulator.
This commit corrects this.

We cannot yet provide a way for users to set plain text
in InstantiatingChannelProvider, since usePlaintext
is still a beta API.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 663da74 on pongad:pub-sub-emu-doc into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM.

It occurred to me that we are calling usePlaintext from GrpcLoggingRpc, which is a problem (but outside the scope of this PR).

@pongad pongad merged commit ff2b1b6 into googleapis:master Jul 19, 2017
@pongad pongad deleted the pub-sub-emu-doc branch July 19, 2017 23:51
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
…#2254)

* chore: Update generation configuration at Sat Oct 26 02:24:29 UTC 2024

* chore: Update generation configuration at Sun Oct 27 02:29:11 UTC 2024

* chore: Update generation configuration at Tue Oct 29 02:27:44 UTC 2024

* chore: Update generation configuration at Wed Oct 30 02:27:20 UTC 2024

* chore: Update generation configuration at Thu Oct 31 02:27:54 UTC 2024

* chore: Update generation configuration at Fri Nov  1 02:30:31 UTC 2024

* chore: Update generation configuration at Sat Nov  2 02:25:12 UTC 2024

* chore: generate libraries at Sat Nov  2 02:25:54 UTC 2024

* chore: Update generation configuration at Tue Nov  5 02:25:23 UTC 2024

* chore: Update generation configuration at Wed Nov  6 02:24:47 UTC 2024
meltsufin pushed a commit that referenced this pull request May 1, 2026
…#2254)

* chore: Update generation configuration at Sat Oct 26 02:24:29 UTC 2024

* chore: Update generation configuration at Sun Oct 27 02:29:11 UTC 2024

* chore: Update generation configuration at Tue Oct 29 02:27:44 UTC 2024

* chore: Update generation configuration at Wed Oct 30 02:27:20 UTC 2024

* chore: Update generation configuration at Thu Oct 31 02:27:54 UTC 2024

* chore: Update generation configuration at Fri Nov  1 02:30:31 UTC 2024

* chore: Update generation configuration at Sat Nov  2 02:25:12 UTC 2024

* chore: generate libraries at Sat Nov  2 02:25:54 UTC 2024

* chore: Update generation configuration at Tue Nov  5 02:25:23 UTC 2024

* chore: Update generation configuration at Wed Nov  6 02:24:47 UTC 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants