Fix ConcurrentModificationException when flushing async log messages by stalar · Pull Request #2213 · googleapis/google-cloud-java

stalar · 2017-07-03T09:56:55Z

A missing synchronized statement when adding to pendingWrites cause
ConcurrentModificationExceptions in the flush() method when the
pendingWrites are copied to writesToFlush.

Fixes #2207.

googlebot · 2017-07-03T09:56:58Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

coveralls · 2017-07-03T10:17:05Z

Coverage increased (+0.002%) to 81.137% when pulling 18f5da9 on stalar:master into 2a92207 on GoogleCloudPlatform:master.

coveralls · 2017-07-03T11:51:32Z

Coverage increased (+0.01%) to 81.149% when pulling 916b4f0 on stalar:master into 2a92207 on GoogleCloudPlatform:master.

A missing synchronized statement when adding to pendingWrites cause ConcurrentModificationExceptions in the flush() method when the pendingWrites are copied to writesToFlush.

coveralls · 2017-07-03T13:31:16Z

Coverage increased (+0.006%) to 81.141% when pulling e7d1adf on stalar:master into 2a92207 on GoogleCloudPlatform:master.

stalar · 2017-07-03T13:33:40Z

I signed it!

Or at least Spotify signed it and I have tried to commit using my @spotify.com email address, but it does not look like it is working?

coveralls · 2017-07-05T08:18:30Z

Coverage increased (+0.002%) to 81.137% when pulling e7d1adf on stalar:master into 2a92207 on GoogleCloudPlatform:master.

michaelbausor

Thanks for the PR, this looks good!

Regarding the CLA, you could try:

Check that your Spotify email address is added to your Github account. It doesn't need to be the primary email, but it should be added. See instructions here: https://help.github.com/articles/adding-an-email-address-to-your-github-account/
If that is done, make sure you are added to the group of authorized contributors for Spotify

Please let me know if those steps don't work, or if you don't know who your Point of Contact inside Spotify is to get added to the authorized contributors group.

Sign in to view

+            logging.write(ImmutableList.of(LOG_ENTRY1));
+            logging.flush();
+          } catch (Exception ex) {
+            ex.printStackTrace();


stalar · 2017-07-06T17:41:46Z

Thanks for taking a look at the PR!

About the CLA:

My spotify email address is added to my GitHub account (although it wasn't when I created the commit and the pull request).
I have been added to the group of authorized contributors for Spotify

Should I just try a new PR?

googlebot · 2017-07-06T17:41:48Z

CLAs look good, thanks!

stalar · 2017-07-06T17:43:48Z

Thanks googlebot!

coveralls · 2017-07-06T18:14:16Z

Coverage increased (+0.006%) to 81.141% when pulling 1356a05 on stalar:master into 2a92207 on GoogleCloudPlatform:master.

JoshuaFox · 2018-02-14T10:55:09Z

Bug still occurs for me
Using com.google.cloud:google-cloud-logging:jar:1.16
Flexible Environment GA


java.util.ConcurrentModificationException at
 java.util.IdentityHashMap$KeySet.toArray(IdentityHashMap.java:1037) at
 java.util.IdentityHashMap$KeySet.toArray(IdentityHashMap.java:1015) at
 java.util.Collections$SetFromMap.toArray(Collections.java:5463) at
 java.util.ArrayList.addAll(ArrayList.java:577) at
 com.google.cloud.logging.LoggingImpl.flush(LoggingImpl.java:539) at
 com.google.cloud.logging.LoggingImpl.write(LoggingImpl.java:525) at
 com.google.cloud.logging.LoggingHandler.publish(LoggingHandler.java:273) at
 java.util.logging.Logger.log(Logger.java:738) at
 java.util.logging.Logger.doLog(Logger.java:765) at
 java.util.logging.Logger.log(Logger.java:788) at
 java.util.logging.Logger.severe(Logger.java:1464) a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…#2213)

…v3.51.0 (#2213)

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 3, 2017

stalar force-pushed the master branch from 18f5da9 to 916b4f0 Compare July 3, 2017 11:00

Fix ConcurrentModificationException when flushing async log messages

e7d1adf

A missing synchronized statement when adding to pendingWrites cause ConcurrentModificationExceptions in the flush() method when the pendingWrites are copied to writesToFlush.

stalar force-pushed the master branch from 916b4f0 to e7d1adf Compare July 3, 2017 12:40

stalar closed this Jul 5, 2017

stalar reopened this Jul 5, 2017

michaelbausor reviewed Jul 6, 2017

View reviewed changes

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 6, 2017

Remove call to printStackTrace()

1356a05

michaelbausor approved these changes Jul 6, 2017

View reviewed changes

michaelbausor merged commit 797d665 into googleapis:master Jul 6, 2017

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

chore(main): release 2.33.0 (googleapis#2213)

115c69c

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

meltsufin pushed a commit that referenced this pull request Apr 29, 2026

deps: update dependency com.google.cloud:google-cloud-core to v2.45.0 (…

5ee969b

…#2213)

meltsufin pushed a commit that referenced this pull request May 1, 2026

deps: update dependency com.google.cloud:google-cloud-core to v2.45.0 (…

a386c01

…#2213)

meltsufin pushed a commit that referenced this pull request May 2, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

f1b3505

…v3.51.0 (#2213)

Conversation

stalar commented Jul 3, 2017

Uh oh!

googlebot commented Jul 3, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

stalar commented Jul 3, 2017

Uh oh!

coveralls commented Jul 5, 2017

Uh oh!

michaelbausor left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

stalar commented Jul 6, 2017

Uh oh!

googlebot commented Jul 6, 2017

Uh oh!

stalar commented Jul 6, 2017

Uh oh!

coveralls commented Jul 6, 2017

Uh oh!

JoshuaFox commented Feb 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants