Skip to content

fix wrong logging filter format, which causes 502 error#2145

Merged
neozwu merged 5 commits intogoogleapis:masterfrom
neozwu:fix-logging-IT
Jun 15, 2017
Merged

fix wrong logging filter format, which causes 502 error#2145
neozwu merged 5 commits intogoogleapis:masterfrom
neozwu:fix-logging-IT

Conversation

@neozwu
Copy link
Copy Markdown
Contributor

@neozwu neozwu commented Jun 13, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2017
garrettjonesgoogle
garrettjonesgoogle reviewed Jun 13, 2017
View reviewed changes
google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java Outdated
logger.setLevel(Level.INFO);
logger.info("Message");
String filter =
"logName = projects/" + logging().getOptions().getProjectId() + "/logs/" + logName;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2017

Coverage Status

Changes Unknown when pulling 9177fb9 on neozwu:fix-logging-IT into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2017

Coverage Status

Changes Unknown when pulling 2b535b5 on neozwu:fix-logging-IT into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle
garrettjonesgoogle reviewed Jun 14, 2017
View reviewed changes
google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java
LogEntry firstEntry = LogEntry.newBuilder(firstPayload)
.addLabel("key1", "value1")
.setLogName(logName)
.setLogName(logId)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java Outdated
.build();
logging().write(ImmutableList.of(firstEntry));
logging().write(ImmutableList.of(secondEntry));
String filter = "logName = " + logName.toString();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java Outdated
public void testDeleteNonExistingLogAsync() throws ExecutionException, InterruptedException {
String logName = formatForTest("test-delete-non-existing-log-async");
assertFalse(logging().deleteLogAsync(logName).get());
String logId= formatForTest("test-delete-non-existing-log-async");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2017

Coverage Status

Changes Unknown when pulling ca560c7 on neozwu:fix-logging-IT into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle
garrettjonesgoogle reviewed Jun 14, 2017
View reviewed changes
google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java
LogEntry firstEntry = LogEntry.newBuilder(firstPayload)
.addLabel("key1", "value1")
.setLogName(logName)
.setLogName(logId)

This comment was marked as spam.

Sign in to view

google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java Outdated
/**
* Creates a comparison expression for logging filter.
*/
protected abstract <V> String createComparisonExpression(String name, String op, V value);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java Outdated
.build();
logging().write(ImmutableList.of(firstEntry));
logging().write(ImmutableList.of(secondEntry));
String filter = createComparisonExpression("logName", "=", logName);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle approved these changes Jun 14, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2017

Coverage Status

Changes Unknown when pulling 0677adf on neozwu:fix-logging-IT into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2017

Coverage Status

Changes Unknown when pulling 0677adf on neozwu:fix-logging-IT into ** on GoogleCloudPlatform:master**.

@neozwu neozwu merged commit c6d6b4f into googleapis:master Jun 15, 2017
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
deps: update dependency org.apache.arrow:arrow-vector to v12.0.1 (#2145)
34dfda6
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@release-please
chore(main): release 2.38.0 (#2139)
135d4e5 
🤖 I have created a release *beep* *boop*
---


## [2.38.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.37.2...v2.38.0) (2023-06-13)


### Features

* Add storage error codes for KMS ([5d2d3c6](https://togithub.com/googleapis/java-bigquerystorage/commit/5d2d3c6fc6be14a3cb79cf0ce0e82b48699a97c4))
* Add table sampling to ReadAPI v1 ([5d2d3c6](https://togithub.com/googleapis/java-bigquerystorage/commit/5d2d3c6fc6be14a3cb79cf0ce0e82b48699a97c4))


### Bug Fixes

* Update copyright year in Java license header replacement template ([#1810](https://togithub.com/googleapis/java-bigquerystorage/issues/1810)) ([#2138](https://togithub.com/googleapis/java-bigquerystorage/issues/2138)) ([af99efe](https://togithub.com/googleapis/java-bigquerystorage/commit/af99efe938302e0d09c98308ad081244d9c5633e))


### Dependencies

* Update arrow.version to v12.0.1 ([#2143](https://togithub.com/googleapis/java-bigquerystorage/issues/2143)) ([7fb618e](https://togithub.com/googleapis/java-bigquerystorage/commit/7fb618e16b6a06278d511e771b8b46ebf4658aa9))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.27.0 ([#2131](https://togithub.com/googleapis/java-bigquerystorage/issues/2131)) ([e459348](https://togithub.com/googleapis/java-bigquerystorage/commit/e4593486959e86808255517861361805dc8769aa))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#2137](https://togithub.com/googleapis/java-bigquerystorage/issues/2137)) ([5fe7cdb](https://togithub.com/googleapis/java-bigquerystorage/commit/5fe7cdb6c9b6899a13b0fdde0a5a436d68a509e2))
* Update dependency org.apache.arrow:arrow-memory-netty to v12.0.1 ([#2144](https://togithub.com/googleapis/java-bigquerystorage/issues/2144)) ([e738bff](https://togithub.com/googleapis/java-bigquerystorage/commit/e738bff88e3efaf0f6beb5f2d93057a175671d3e))
* Update dependency org.apache.arrow:arrow-vector to v12.0.1 ([#2145](https://togithub.com/googleapis/java-bigquerystorage/issues/2145)) ([34dfda6](https://togithub.com/googleapis/java-bigquerystorage/commit/34dfda6aeec700c0722ad559e71e85bdedd04bfb))
* Update dependency org.mockito:mockito-core to v3.12.4 ([#2146](https://togithub.com/googleapis/java-bigquerystorage/issues/2146)) ([1434fc0](https://togithub.com/googleapis/java-bigquerystorage/commit/1434fc0b995f5d6c8039acca8ca530e9d11f490b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neozwu @coveralls @garrettjonesgoogle @googlebot