pubsub: start subscriber connections quickly again#2104
Merged
pongad merged 1 commit intogoogleapis:masterfrom Jun 6, 2017
pongad:fix-subscribe
Merged
pubsub: start subscriber connections quickly again#2104pongad merged 1 commit intogoogleapis:masterfrom pongad:fix-subscribe
pongad merged 1 commit intogoogleapis:masterfrom
pongad:fix-subscribe
Conversation
This PR undoes part of #2055. Refreshing credentials blocks thread for a period of time. Previously, each channel has its own credentials, so starting many channels spams executor with many blocking tasks. but the downside is we take a long time to fully start: about 2 minutes on my machine. Now, all connections share the same credentials, so refreshing only happens once. We can start quickly again. Also rename setLeaseAlarmsExecutorProvider, since the executor is now also used for polling.
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 07f1c28 on pongad:fix-subscribe into ** on GoogleCloudPlatform:master**. |
| * is provided a shared one will be used by all {@link Subscriber} instances. | ||
| */ | ||
| public Builder setLeaseAlarmsExecutorProvider(ExecutorProvider executorProvider) { | ||
| public Builder setSystemExecutorProvider(ExecutorProvider executorProvider) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM |
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
* feat: Adding setting KeepAlive to JsonWriter sample * . * . * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
We will soon disable the Owlbot postprocessor. This is part of the effort to enable hermetic generation in this repo ([context](https://docs.google.com/document/d/1wrpyBtphdenM3BNelcnpBKGADYrGJUo686HXvSA0h-0/edit?pli=1&tab=t.0#bookmark=kix.914gcjvdwt3u))
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
We will soon disable the Owlbot postprocessor. This is part of the effort to enable hermetic generation in this repo ([context](https://docs.google.com/document/d/1wrpyBtphdenM3BNelcnpBKGADYrGJUo686HXvSA0h-0/edit?pli=1&tab=t.0#bookmark=kix.914gcjvdwt3u))
meltsufin
pushed a commit
that referenced
this pull request
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR undoes part of #2055.
Refreshing credentials blocks thread for a period of time.
Previously, each channel has its own credentials,
so starting many channels spams executor with many blocking tasks.
but the downside is we take a long time to fully start:
about 2 minutes on my machine.
Now, all connections share the same credentials,
so refreshing only happens once.
We can start quickly again.
Also rename setLeaseAlarmsExecutorProvider,
since the executor is now also used for polling.