Skip to content

[NIO] Inconsistent failure messages fix#2096

Closed
vam-google wants to merge 1 commit intomasterfrom
vam-google-patch-1
Closed

[NIO] Inconsistent failure messages fix#2096
vam-google wants to merge 1 commit intomasterfrom
vam-google-patch-1

Conversation

@vam-google
Copy link
Copy Markdown
Contributor

#2090

Fixing only the example case, mentioned in the issue description.

#2090

Fixing only the example case, mentioned in the issue description.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2017
@vam-google
Copy link
Copy Markdown
Contributor Author

Requesting review from @garrettjonesgoogle, as I could not add @Horneth as a reviewer

if (null == blobInfo || blobInfo.getSize() == null) {
throw new NoSuchFileException(
cloudPath.getBlobId().getBucket() + "/" + cloudPath.getBlobId().getName());
"gs://" + cloudPath.getBlobId().getBucket() + "/" + cloudPath.getBlobId().getName());

This comment was marked as spam.

This comment was marked as spam.

@Horneth
Copy link
Copy Markdown

Horneth commented May 30, 2017

@vam-google Looks good to me 👍 Thanks !

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling cd5f433 on vam-google-patch-1 into ** on master**.

@vam-google
Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of an already merged PR #2330

@vam-google vam-google closed this Aug 11, 2017
@vam-google vam-google deleted the vam-google-patch-1 branch August 11, 2017 16:00
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
… always (#2096)

* fix: pass the parameter value of enableConnectionPool instead of true always

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
🤖 I have created a release *beep* *boop*
---


## [2.37.2](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.37.1...v2.37.2) (2023-05-30)


### Bug Fixes

* Pass the parameter value of enableConnectionPool instead of true always ([#2096](https://togithub.com/googleapis/java-bigquerystorage/issues/2096)) ([253678d](https://togithub.com/googleapis/java-bigquerystorage/commit/253678df630c717fbcf7018b3245aa56b5f22660))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.26.0 ([#2114](https://togithub.com/googleapis/java-bigquerystorage/issues/2114)) ([8b44534](https://togithub.com/googleapis/java-bigquerystorage/commit/8b4453476b17dcbb10faaa52c6a2b06506d89d62))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.26.1 ([#2128](https://togithub.com/googleapis/java-bigquerystorage/issues/2128)) ([62afd46](https://togithub.com/googleapis/java-bigquerystorage/commit/62afd46bb4cad09886c49bac88a2052c8754f8fe))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.10.1 ([#2121](https://togithub.com/googleapis/java-bigquerystorage/issues/2121)) ([3fabc5d](https://togithub.com/googleapis/java-bigquerystorage/commit/3fabc5d467becd3d9b816f9545e8a1e6dd09f682))
* Update dependency com.google.http-client:google-http-client to v1.43.2 ([#2109](https://togithub.com/googleapis/java-bigquerystorage/issues/2109)) ([0d57daf](https://togithub.com/googleapis/java-bigquerystorage/commit/0d57daff0d113089ba1957753febeed92024e4c2))
* Update dependency com.google.truth:truth to v1.1.4 ([#2126](https://togithub.com/googleapis/java-bigquerystorage/issues/2126)) ([a0be7ad](https://togithub.com/googleapis/java-bigquerystorage/commit/a0be7ad59b1604972b190befe2e4befd2e2c6431))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants