add-max-retry-property-support#2062
Conversation
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 779f526 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 779f526 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**. |
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
Thank you for this! Some style comments, but otherwise LGTM.
| } | ||
|
|
||
|
|
||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| import io.grpc.ManagedChannel; | ||
| import io.grpc.Status; | ||
| import org.threeten.bp.Duration; | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 00582b8 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 49b4e32 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 49b4e32 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**. |
* fix: add a e2e json test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…yle-plugin to v3.4.0 (#2062) * build(deps): update dependency org.apache.maven.plugins:maven-checkstyle-plugin to v3.4.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…yle-plugin to v3.4.0 (#2062) * build(deps): update dependency org.apache.maven.plugins:maven-checkstyle-plugin to v3.4.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 participants
RetrySettings contain property
maxAttemptwhich is not used by Publisher.Added support for maxAttempt, which gives developer control a bit more over retries.