pubsub: delete Subscriber.Builder::setCredentials by pongad · Pull Request #1975 · googleapis/google-cloud-java

pongad · 2017-04-24T04:19:03Z

The credentials provided to this method is not used.
Currently the credentials should be set in the ChannelProvider.

Updates #1959.

The credentials provided to this method is not used. Currently the credentials should be set in the ChannelProvider. Updates #1959.

coveralls · 2017-04-24T04:28:36Z

Changes Unknown when pulling af98a13 on pongad:sub-cred into ** on GoogleCloudPlatform:master**.

kamalaboulhosn

We should also remove the comment from Subscriber.java and Publisher.java that says "If no credentials are provided, the {@link Subscriber} will use application default credentials through {@link GoogleCredentials#getApplicationDefault}." since there is no way to change the credentials in these classes at this time.

pongad · 2017-04-24T22:14:13Z

@kamalaboulhosn There is actually a way to change credentials: by changing the ChannelProvider. I'm not sure how to best document this.

@garrettjonesgoogle Do we have a central doc somewhere detailing how to change credentials? We can create a .md file somewhere in the repo and link to it in docs. WDYT?

garrettjonesgoogle · 2017-04-26T22:34:47Z

@pongad could you nominate another person in our team to do this review?

pongad · 2017-04-26T22:41:53Z

Nominating @vam-google since we were just talking about this 😆

vam-google

LGTM.

Sign in to view

 import com.google.api.gax.grpc.ChannelProvider;
 import com.google.api.gax.grpc.ExecutorProvider;
 import com.google.api.gax.grpc.InstantiatingExecutorProvider;
-import com.google.auth.Credentials;


Sign in to view

            .build();

    SubscriptionName subscriptionName;
-    Optional<Credentials> credentials = Optional.absent();


Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: Split writer into connection worker and wrapper, this is a prerequisite for multiplexing client * feat: add connection worker pool skeleton, used for multiplexing client * feat: add Load api for connection worker for multiplexing client * feat: add multiplexing support to connection worker. We will treat every new stream name as a switch of destinationt * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: port the multiplexing client core algorithm and basic tests also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: wire multiplexing connection pool to stream writer * feat: some fixes for multiplexing client * feat: fix some todos, and reject the mixed behavior of passed in client or not * feat: fix the bug that we may peek into the write_stream field but it's possible the proto schema does not contain this field * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: fix the bug that we may peek into the write_stream field but it's possible the proto schema does not contain this field * feat: add getInflightWaitSeconds implementation * feat: Add schema comparision in connection loop to ensure schema update for the same stream name can be notified * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add schema update support to multiplexing * fix: fix windows build bug: windows Instant resolution is different with linux * fix: fix another failing tests for windows build * fix: fix another test failure for Windows build * feat: Change new thread for each retry to be a thread pool to avoid create/tear down too much threads if lots of retries happens * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: add back the background executor provider that's accidentally removed * feat: throw error when use connection pool for explicit stream * fix: Add precision truncation to the passed in value from JSON float and double type. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * modify the bom version * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix deadlockissue in ConnectionWorkerPool * fix: fix deadlock issue during close + append for multiplexing * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: fix one potential root cause of deadlock issue for non-multiplexing case * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add timeout to inflight queue waiting, and also add some extra log * feat: allow java client lib handle switch table schema for the same stream name * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: close before retry connection * fix: close before retry connection --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Use the call stack the first time that a JDBC connection is being created to determine whether the connection should use the sp-jdbc or sp-hib user-agent token.

* deps: update actions/checkout action to v4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.128.1](https://togithub.com/googleapis/java-pubsub/compare/v1.128.0...v1.128.1) (2024-04-10) ### Dependencies * Update actions/checkout action to v4 ([#1975](https://togithub.com/googleapis/java-pubsub/issues/1975)) ([618abdd](https://togithub.com/googleapis/java-pubsub/commit/618abdd44dd9670a5d6a1ca3c923e3d0621c6248)) * Update actions/github-script action to v7 ([#1976](https://togithub.com/googleapis/java-pubsub/issues/1976)) ([c836172](https://togithub.com/googleapis/java-pubsub/commit/c8361722544ec4170b94651e77b02634938c7883)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* deps: update actions/checkout action to v4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.128.1](https://togithub.com/googleapis/java-pubsub/compare/v1.128.0...v1.128.1) (2024-04-10) ### Dependencies * Update actions/checkout action to v4 ([#1975](https://togithub.com/googleapis/java-pubsub/issues/1975)) ([6fc17f2](https://togithub.com/googleapis/java-pubsub/commit/6fc17f288e40d12110ce8daeddb48daf1389115d)) * Update actions/github-script action to v7 ([#1976](https://togithub.com/googleapis/java-pubsub/issues/1976)) ([e6b8d63](https://togithub.com/googleapis/java-pubsub/commit/e6b8d63a68f39e939aad12db762746aeb0f66c77)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…v1 to v2.56.0 (#1975)

pubsub: delete Subscriber.Builder::setCredentials

af98a13

The credentials provided to this method is not used. Currently the credentials should be set in the ChannelProvider. Updates #1959.

pongad requested a review from garrettjonesgoogle April 24, 2017 04:19

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2017

kamalaboulhosn suggested changes Apr 24, 2017

View reviewed changes

pongad requested a review from vam-google April 26, 2017 22:41

vam-google approved these changes Apr 27, 2017

View reviewed changes

garrettjonesgoogle merged commit a740201 into googleapis:master Apr 28, 2017

pongad deleted the sub-cred branch April 30, 2017 04:59

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore(main): release 2.32.3-SNAPSHOT (#1975)

2305410

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

chore(main): release 2.32.3-SNAPSHOT (#1975)

ba4bc2f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

meltsufin pushed a commit that referenced this pull request May 2, 2026

deps: update dependency com.google.api.grpc:proto-google-cloud-trace-…

d1cf419

…v1 to v2.56.0 (#1975)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pubsub: delete Subscriber.Builder::setCredentials#1975

pubsub: delete Subscriber.Builder::setCredentials#1975
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
pongad:sub-cred

pongad commented Apr 24, 2017

Uh oh!

coveralls commented Apr 24, 2017

Uh oh!

kamalaboulhosn left a comment

Uh oh!

pongad commented Apr 24, 2017

Uh oh!

garrettjonesgoogle commented Apr 26, 2017

Uh oh!

pongad commented Apr 26, 2017

Uh oh!

vam-google left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

pongad commented Apr 24, 2017

Uh oh!

coveralls commented Apr 24, 2017

Uh oh!

kamalaboulhosn left a comment

Choose a reason for hiding this comment

Uh oh!

pongad commented Apr 24, 2017

Uh oh!

garrettjonesgoogle commented Apr 26, 2017

Uh oh!

pongad commented Apr 26, 2017

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants