Skip to content

Removing timeout settings that are set but never used#1934

Merged
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:alt
Apr 18, 2017
Merged

Removing timeout settings that are set but never used#1934
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:alt

Conversation

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.008%) to 80.933% when pulling 730394c on garrettjonesgoogle:alt into b6a87b0 on GoogleCloudPlatform:master.

@michaelbausor
Copy link
Copy Markdown
Contributor

LGTM - did these used to be used? Or have they never been used at all?

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor Author

Yes, they used to be used, but @vam-google 's PR #1738 stopped using them after RetrySettings was introduced. Now, going through RetrySettings (which can be set on ServiceOptions) is the correct thing to do.

@garrettjonesgoogle garrettjonesgoogle merged commit 455f739 into googleapis:master Apr 18, 2017
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Add a couple of tests to verify that multiplexed sessions are being used
by the JDBC driver when the environment variable has been set.
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 2, 2026
* chore(main): release 3.30.0

* chore: generate libraries at Tue Nov 26 14:15:13 UTC 2024

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants