Improve GCS signUrlOption javadoc#1928
Merged
andreamlin merged 2 commits intogoogleapis:masterfrom Jan 9, 2018
Merged
Conversation
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 6bb1ae7 on danielcompton:gcs-docs into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 6bb1ae7 on danielcompton:gcs-docs into ** on GoogleCloudPlatform:master**. |
Contributor
|
@danielcompton , did you want to finish this PR? |
Author
|
I think this is ready to merge if you're happy with the wording? |
Contributor
|
@andreamlin can you verify the correctness of the new comments and merge if it looks good? |
andreamlin
reviewed
Jan 8, 2018
|
|
||
| /** | ||
| * The HTTP method to be used with the signed URL. | ||
| * The HTTP method to be used with the signed URL. Defaults to GET. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
…e-utils to v2.31.0 (#1928)
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 2, 2026
…v3.40.0 (#1928) * deps: update sdk-platform-java dependencies * fix: Error for Used undeclared dependencies found by declaring http-client dependencies --------- Co-authored-by: Jin Seop Kim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't quite ready for merge yet. I'm not sure if there is a better wording for the
withContentTypedoc, and whether thehttpMethoddoc should actually go againstStorage.signUrl?