Skip to content

Make sure Storage does not do name normalization#1908

Closed
shinfan wants to merge 1 commit intogoogleapis:masterfrom
shinfan:master
Closed

Make sure Storage does not do name normalization#1908
shinfan wants to merge 1 commit intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Contributor

@shinfan shinfan commented Apr 12, 2017

Fixes #1837

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2017
@jskeet
Copy link

jskeet commented Apr 12, 2017

Sorry, I'm on vacation until Tuesday so I probably won't be able to review this until then.

garrettjonesgoogle
garrettjonesgoogle reviewed Apr 12, 2017
View reviewed changes
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java Outdated
@Test
public void testBlobNameNormalization() {
for (String blobName : BLOB_NORMALIZATION.keySet()) {
BlobInfo blobInfoFormC = BlobInfo.newBuilder(BlobId.of(BUCKET, blobName))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@shinfan
Copy link
Contributor Author

shinfan commented Apr 12, 2017

@jskeet No worries :)

@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage decreased (-0.004%) to 80.969% when pulling 698ea95 on shinfan:master into f9e7ecc on GoogleCloudPlatform:master.

@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage increased (+0.004%) to 80.955% when pulling 851e93c on shinfan:master into 56d0a30 on GoogleCloudPlatform:master.

jskeet
jskeet reviewed Apr 19, 2017
View reviewed changes
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java Outdated
.setContentType("text/plain")
.setContentEncoding("UTF-8")
.build();
Blob blob = storage.create(blobInfo, BLOB_NORMALIZATION.get(blobName).getBytes());

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented May 18, 2017

Coverage Status

Coverage decreased (-0.002%) to 80.94% when pulling 14fae1e on shinfan:master into c73d3b0 on GoogleCloudPlatform:master.

@shinfan
Copy link
Contributor Author

shinfan commented May 18, 2017

Oops I updated this branch by mistake. I will fix this.

@coveralls
Copy link

coveralls commented Jun 26, 2017

Coverage Status

Changes Unknown when pulling b37a624 on shinfan:master into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jul 18, 2017

@shinfan could you maybe create a PR off of a different branch so that it isn't prone to getting overwritten?

@shinfan shinfan closed this Jul 18, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@gcf-owl-bot @dependabot @cindy-peng
build(deps): bump cryptography from 41.0.3 to 41.0.6 in /synthtool/gc…
d1f8ff8 
…p/templates/java_library/.kokoro (#1908) (#1491)

build(deps): bump cryptography

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.6)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...



Source-Link: googleapis/synthtool@ea6f800
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cindy Peng <[email protected]>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@gcf-owl-bot @dependabot @cindy-peng
build(deps): bump cryptography from 41.0.3 to 41.0.6 in /synthtool/gc…
bba7c5a 
…p/templates/java_library/.kokoro (#1908) (#1225)

build(deps): bump cryptography

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.6)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...



Source-Link: googleapis/synthtool@ea6f800
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cindy Peng <[email protected]>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@gcf-owl-bot @dependabot
build(deps): bump cryptography from 41.0.3 to 41.0.6 in /synthtool/gc…
6e62444 
…p/templates/java_library/.kokoro (#1908) (#1256)

build(deps): bump cryptography

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.6)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...



Source-Link: googleapis/synthtool@ea6f800
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@renovate-bot @cindy-peng
deps: update dependency com.google.cloud:sdk-platform-java-config to …
b10e0f0 
…v3.50.1 (#1908)

Co-authored-by: Cindy Peng <[email protected]>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@release-please
chore(main): release 2.31.0 (#1916)
0fd4981 
🤖 I have created a release *beep* *boop*
---


## [2.31.0](https://togithub.com/googleapis/java-datastore/compare/v2.30.0...v2.31.0) (2025-07-14)


### Features

* Next release from main branch is 2.31.0 ([#1912](https://togithub.com/googleapis/java-datastore/issues/1912)) ([a74c46b](https://togithub.com/googleapis/java-datastore/commit/a74c46bfbac8eaf5c97fe653b740e26e7c79f4da))


### Dependencies

* Update dependency com.google.cloud:gapic-libraries-bom to v1.61.0 ([#1901](https://togithub.com/googleapis/java-datastore/issues/1901)) ([beeb125](https://togithub.com/googleapis/java-datastore/commit/beeb125efc842776facfa67742bdf8b6c167e9f2))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.50.1 ([#1908](https://togithub.com/googleapis/java-datastore/issues/1908)) ([b10e0f0](https://togithub.com/googleapis/java-datastore/commit/b10e0f0748decf06574fc0eb7ddba33ee5ece1a7))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@gcf-owl-bot @dependabot
build(deps): bump cryptography from 41.0.3 to 41.0.6 in /synthtool/gc…
3c08b4f 
…p/templates/java_library/.kokoro (#1908) (#2354)

build(deps): bump cryptography

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.6)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...



Source-Link: googleapis/synthtool@ea6f800
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jskeet jskeet jskeet left review comments

@michaelbausor michaelbausor Awaiting requested review from michaelbausor

+1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shinfan @jskeet @coveralls @garrettjonesgoogle @googlebot