Skip to content

Change AckReplyConsumer to expose individual methods for replying#1899

Merged
garrettjonesgoogle merged 4 commits intogoogleapis:masterfrom
davidtorres:remove-ack-reply-enum
Apr 12, 2017
Merged

Change AckReplyConsumer to expose individual methods for replying#1899
garrettjonesgoogle merged 4 commits intogoogleapis:masterfrom
davidtorres:remove-ack-reply-enum

Conversation

@davidtorres
Copy link
Copy Markdown

@davidtorres davidtorres commented Apr 11, 2017

@garrettjonesgoogle PTAL

Note I have renamed one example file, I'm not sure if that will have unintended consequences (like in docs), please let me know.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 11, 2017

Coverage Status

Changes Unknown when pulling 6d6bff6 on davidtorres:remove-ack-reply-enum into ** on GoogleCloudPlatform:master**.

pongad
pongad previously requested changes Apr 12, 2017
View reviewed changes
Comment thread ...ain/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndConsumeMessages.java
* asynchronously pull messages from it.
*/
public class CreateSubscriptionAndPullMessages {
public class CreateSubscriptionAndConsumeMessages {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/SubscriberImplTest.java Outdated
private final LinkedBlockingQueue<AckReplyConsumer> outstandingMessageReplies =
new LinkedBlockingQueue<>();
private AckReply ackReply = AckReply.ACK;
private boolean shouldAck = true;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 12, 2017
Closed
@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Apr 12, 2017

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit eea1a58 into googleapis:master Apr 12, 2017
@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 12, 2017
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 12, 2017

Coverage Status

Changes Unknown when pulling 03f6abc on davidtorres:remove-ack-reply-enum into ** on GoogleCloudPlatform:master**.

meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@blakeli0 @cloud-java-bot
tests: Ignore flaky tests in ITSinkTest (#1899)
0f244af 
* tests: Ignore flaky tests in ITSinkTest

* chore: generate libraries at Thu Dec 11 21:55:08 UTC 2025

---------

Co-authored-by: cloud-java-bot <[email protected]>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@cloud-java-bot
chore: Update generation configuration at Mon Jul 28 16:10:07 UTC 2025 (
06372cd 
#1899)

* chore: Update generation configuration at Thu Jun 26 02:31:44 UTC 2025

* chore: generate libraries at Thu Jun 26 02:32:12 UTC 2025

* chore: Update generation configuration at Fri Jun 27 02:32:03 UTC 2025

* chore: Update generation configuration at Sat Jun 28 02:30:19 UTC 2025

* chore: Update generation configuration at Sun Jun 29 02:39:25 UTC 2025

* chore: Update generation configuration at Tue Jul  1 02:40:34 UTC 2025

* chore: Update generation configuration at Wed Jul  2 02:31:49 UTC 2025

* chore: Update generation configuration at Thu Jul  3 02:32:36 UTC 2025

* chore: Update generation configuration at Fri Jul  4 02:31:28 UTC 2025

* chore: Update generation configuration at Tue Jul  8 02:32:49 UTC 2025

* chore: Update generation configuration at Wed Jul  9 02:33:40 UTC 2025

* chore: generate libraries at Wed Jul  9 02:34:11 UTC 2025

* chore: Update generation configuration at Thu Jul 10 02:33:59 UTC 2025

* chore: Update generation configuration at Fri Jul 11 02:36:06 UTC 2025

* chore: Update generation configuration at Sat Jul 12 02:35:31 UTC 2025

* chore: Update generation configuration at Tue Jul 15 02:38:30 UTC 2025

* chore: Update generation configuration at Wed Jul 16 02:36:20 UTC 2025

* chore: Update generation configuration at Thu Jul 17 02:36:50 UTC 2025

* chore: Update generation configuration at Sat Jul 19 02:33:15 UTC 2025

* chore: Update generation configuration at Tue Jul 22 02:37:19 UTC 2025

* chore: Update generation configuration at Wed Jul 23 02:38:20 UTC 2025

* chore: Update generation configuration at Thu Jul 24 02:37:49 UTC 2025

* chore: Update generation configuration at Thu Jul 24 19:16:27 UTC 2025

* chore: Update generation configuration at Fri Jul 25 02:37:36 UTC 2025

* chore: Update generation configuration at Sat Jul 26 02:34:21 UTC 2025

* chore: Update generation configuration at Mon Jul 28 16:10:07 UTC 2025

* chore: generate libraries at Mon Jul 28 16:10:41 UTC 2025
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@blakeli0 @cloud-java-bot
tests: Ignore flaky tests in ITSinkTest (googleapis#1899)
ba4888e 
* tests: Ignore flaky tests in ITSinkTest

* chore: generate libraries at Thu Dec 11 21:55:08 UTC 2025

---------

Co-authored-by: cloud-java-bot <[email protected]>
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@cloud-java-bot
chore: Update generation configuration at Mon Jul 28 16:10:07 UTC 2025 (
43aa450 
#1899)

* chore: Update generation configuration at Thu Jun 26 02:31:44 UTC 2025

* chore: generate libraries at Thu Jun 26 02:32:12 UTC 2025

* chore: Update generation configuration at Fri Jun 27 02:32:03 UTC 2025

* chore: Update generation configuration at Sat Jun 28 02:30:19 UTC 2025

* chore: Update generation configuration at Sun Jun 29 02:39:25 UTC 2025

* chore: Update generation configuration at Tue Jul  1 02:40:34 UTC 2025

* chore: Update generation configuration at Wed Jul  2 02:31:49 UTC 2025

* chore: Update generation configuration at Thu Jul  3 02:32:36 UTC 2025

* chore: Update generation configuration at Fri Jul  4 02:31:28 UTC 2025

* chore: Update generation configuration at Tue Jul  8 02:32:49 UTC 2025

* chore: Update generation configuration at Wed Jul  9 02:33:40 UTC 2025

* chore: generate libraries at Wed Jul  9 02:34:11 UTC 2025

* chore: Update generation configuration at Thu Jul 10 02:33:59 UTC 2025

* chore: Update generation configuration at Fri Jul 11 02:36:06 UTC 2025

* chore: Update generation configuration at Sat Jul 12 02:35:31 UTC 2025

* chore: Update generation configuration at Tue Jul 15 02:38:30 UTC 2025

* chore: Update generation configuration at Wed Jul 16 02:36:20 UTC 2025

* chore: Update generation configuration at Thu Jul 17 02:36:50 UTC 2025

* chore: Update generation configuration at Sat Jul 19 02:33:15 UTC 2025

* chore: Update generation configuration at Tue Jul 22 02:37:19 UTC 2025

* chore: Update generation configuration at Wed Jul 23 02:38:20 UTC 2025

* chore: Update generation configuration at Thu Jul 24 02:37:49 UTC 2025

* chore: Update generation configuration at Thu Jul 24 19:16:27 UTC 2025

* chore: Update generation configuration at Fri Jul 25 02:37:36 UTC 2025

* chore: Update generation configuration at Sat Jul 26 02:34:21 UTC 2025

* chore: Update generation configuration at Mon Jul 28 16:10:07 UTC 2025

* chore: generate libraries at Mon Jul 28 16:10:41 UTC 2025
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update dependency org.springframework.boot:spring-boot-starter-…
b1c4641 
…parent to v3.4.2 (googleapis#1899)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://redirect.github.com/spring-projects/spring-boot)) | `3.4.1` -> `3.4.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-parent/3.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-parent/3.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-parent/3.4.1/3.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-parent/3.4.1/3.4.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary>

### [`v3.4.2`](https://redirect.github.com/spring-projects/spring-boot/compare/v3.4.1...v3.4.2)

[Compare Source](https://redirect.github.com/spring-projects/spring-boot/compare/v3.4.1...v3.4.2)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/java-spanner-jdbc).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@michaelpri10 @gcf-owl-bot
chore: change assignees for issues and PRs to michaelpri10 (#1899)
77f3c26 
* chore: change assignees for issues and PRs to michaelpri10

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@michaelpri10 @gcf-owl-bot
chore: change assignees for issues and PRs to michaelpri10 (#1899)
a292bf2 
* chore: change assignees for issues and PRs to michaelpri10

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 2, 2026
@renovate-bot
deps: update googleapis/sdk-platform-java action to v2.48.0 (#1899)
217a72a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@pongad pongad pongad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtorres @coveralls @garrettjonesgoogle @pongad @googlebot