force query results to become strongly consistent#1806
Merged
neozwu merged 4 commits intogoogleapis:masterfrom Apr 17, 2017
Merged
force query results to become strongly consistent#1806neozwu merged 4 commits intogoogleapis:masterfrom
neozwu merged 4 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
garrettjonesgoogle
requested review from
vam-google
and removed request for
shinfan
Contributor
|
@vam-google could you do a first pass on this PR? |
Contributor
Author
|
kindly ping @vam-google |
vam-google
reviewed
Mar 29, 2017
| continue infiniteloop; | ||
| } | ||
| } | ||
| return resultsCopy.iterator(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| while(true) { | ||
| QueryResults<T> results = DATASTORE.run(query); | ||
| List<T> resultsCopy = makeResultsCopy(results); | ||
| if (!haveSameSize(scResultsCopy.iterator(), resultsCopy.iterator())) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return results; | ||
| } | ||
|
|
||
| private <T, S> boolean haveSameSize(Iterator<T> it1, Iterator<S> it2) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| results1 = DATASTORE.run(query1); | ||
| } | ||
| results1 = DATASTORE.run(query1); | ||
| Query<Entity> scQuery1 = Query.newEntityQueryBuilder() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| Set<T> scResultsSet = new HashSet<>(scResultsCopy); | ||
|
|
||
| infiniteloop: | ||
| while(true) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| private static final Entity ENTITY3 = Entity.newBuilder(ENTITY1).setKey(KEY3).remove("str") | ||
| .set("null", NULL_VALUE).set("partial1", PARTIAL_ENTITY2).set("partial2", ENTITY2).build(); | ||
|
|
||
| private <T> Iterator<T> getStronglyConsistentResults (Query scQuery, Query query) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@vam-google PTAL |
vam-google
approved these changes
Apr 17, 2017
|
|
||
| private <T> Iterator<T> getStronglyConsistentResults (Query scQuery, Query query) throws InterruptedException { | ||
| //scQuery is equivalent to query, but with an ancestor filter in it | ||
| //This makes scQuery strongly consistent |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 2, 2026
This removes the unused image tag in this file. Part of the cleanup after enabling Hermetic Library generation in this repo. Newline at EOF automatically added - see [this SO](https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outside transactions, global queries of google cloud datastore utilize eventually consistent model - this means query results are not guaranteed to be updated. To facilitate deterministic testing, a helper method is implemented to force strong consistency for global queries. It leverages the fact that any queries with ancestor filter will become strongly consistent queries.