logging: remove handler's buffer#1796
Merged
pongad merged 1 commit intogoogleapis:masterfrom Mar 24, 2017
pongad:logging-sync
Merged
logging: remove handler's buffer#1796pongad merged 1 commit intogoogleapis:masterfrom pongad:logging-sync
pongad merged 1 commit intogoogleapis:masterfrom
pongad:logging-sync
Conversation
LoggingHandler's buffer is redundant, since it's already using the batching feature. LoggingHandler.flush previously just flushes its own buffer and put messages in the batcher's buffer, without necessarily making RPC calls. This PR does not fix this problem, but it makes flush obviously wrong instead of subtly. The test for flush size is also removed. Flush size should be forwareded to the batcher, which already has its own test. Updates #1795.
googlebot
added
the
cla: yes
| buffer = new LinkedList<>(); | ||
| } | ||
| if (entry != null) { | ||
| write(entry, writeOptions); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
🤖 I have created a release *beep* *boop* --- ## [3.22.2](https://togithub.com/googleapis/java-logging/compare/v3.22.1...v3.22.2) (2025-04-25) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.46.2 ([#1796](https://togithub.com/googleapis/java-logging/issues/1796)) ([1f88271](https://togithub.com/googleapis/java-logging/commit/1f882712aeb7e48a2339ffbad783813e11e74401)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.22.2](https://togithub.com/googleapis/java-logging/compare/v3.22.1...v3.22.2) (2025-04-25) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.46.2 ([googleapis#1796](https://togithub.com/googleapis/java-logging/issues/1796)) ([07d6399](https://togithub.com/googleapis/java-logging/commit/07d63995a0034fba3538ceac56aae869b7fdbfbb)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…-info-reports-plugin to v3.8.0 (googleapis#1796)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggingHandler's buffer is redundant,
since it's already using the batching feature.
LoggingHandler.flush previously just flushes its own buffer
and put messages in the batcher's buffer,
without necessarily making RPC calls.
This PR does not fix this problem,
but it makes flush obviously wrong instead of subtly.
The test for flush size is also removed.
Flush size should be forwareded to the batcher,
which already has its own test.
Updates #1795.