Skip to content

Add x-goog-api-client support to HTTP1.1#1790

Merged
shinfan merged 5 commits intogoogleapis:masterfrom
shinfan:master
Mar 23, 2017
Merged

Add x-goog-api-client support to HTTP1.1#1790
shinfan merged 5 commits intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Copy Markdown
Contributor

@shinfan shinfan commented Mar 22, 2017 •
edited
Loading

This PR depends on the GAX change: googleapis/gax-java#250

cc/ @bjwatson

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2017
@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Mar 22, 2017

Note the build will fail until the GAX change is released.

@shinfan shinfan changed the title Add x-goog-api-client suuport to HTTP1.1 Add x-goog-api-client support to HTTP1.1 Mar 22, 2017
garrettjonesgoogle
garrettjonesgoogle reviewed Mar 22, 2017
View reviewed changes
Comment thread google-cloud-core/src/main/java/com/google/cloud/HttpTransportOptions.java Outdated
import com.google.auth.Credentials;
import com.google.auth.http.HttpCredentialsAdapter;
import com.google.auth.http.HttpTransportFactory;
import com.google.common.annotations.VisibleForTesting;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-core/src/main/java/com/google/cloud/HttpTransportOptions.java Outdated
}

@VisibleForTesting
String xApiClientHeader() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-core/src/main/java/com/google/cloud/HttpTransportOptions.java Outdated
@VisibleForTesting
String xApiClientHeader() {
return String.format(
"gl-java/%s %s/%s gax/%s grpc/%s",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 22, 2017
View reviewed changes
Comment thread google-cloud-core/src/main/java/com/google/cloud/HttpTransportOptions.java Outdated
ServiceOptions.getGoogApiClientLibName(),
ServiceOptions.getLibraryVersion(),
GaxPropertiesProvider.getGaxVersion(),
GaxPropertiesProvider.getGrpcVersion());

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 22, 2017

Coverage Status

Changes Unknown when pulling 6996c5a on shinfan:master into ** on GoogleCloudPlatform:master**.

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Mar 22, 2017

@garrettjonesgoogle PTAL. CI passed.

@bjwatson
Copy link
Copy Markdown

bjwatson commented Mar 23, 2017

LGTM, but @garrettjonesgoogle has final approval.

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 23, 2017
View reviewed changes
Comment thread google-cloud-core/src/main/java/com/google/cloud/HttpTransportOptions.java Outdated

String getXGoogApiClientHeader() {
return String.format(
"gl-java/%s %s/%s gax/%s",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 23, 2017

Coverage Status

Changes Unknown when pulling feead82 on shinfan:master into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 23, 2017
View reviewed changes
Comment thread pom.xml
<google.auth.version>0.6.0</google.auth.version>
<grpc.version>1.0.3</grpc.version>
<gax.version>0.6.0</gax.version>
<gax.version>0.6.1</gax.version>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-core/src/main/java/com/google/cloud/HttpTransportOptions.java

String getXGoogApiClientHeader() {
return String.format(
"gl-java/%s %s/%s",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Mar 23, 2017

LGTM

@shinfan shinfan merged commit afdb204 into googleapis:master Mar 23, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@cloud-java-bot @diegomarquezp
chore: Update generation configuration at Thu Apr 24 02:28:57 UTC 2025 (
7cce5b5 
#1790)

* chore: Update generation configuration at Wed Apr 23 17:13:26 UTC 2025

* chore: generate libraries at Wed Apr 23 17:14:00 UTC 2025

* chore: Update generation configuration at Thu Apr 24 02:28:57 UTC 2025

* chore: manually update generation configuration

* chore: generate libraries at Thu Apr 24 14:52:36 UTC 2025

* chore: update libraries bom version to the latest

* chore: generate libraries at Thu Apr 24 14:58:18 UTC 2025

* chore: remove old kokoro jobs

---------

Co-authored-by: Diego Marquez <[email protected]>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@nbayati
docs: Update README with X.509 feature details (#1790)
7b51cb3 
* docs: Update README with X.509 feature details.

* Address the review comments
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@cloud-java-bot @diegomarquezp
chore: Update generation configuration at Thu Apr 24 02:28:57 UTC 2025 (
2e156b7 
googleapis#1790)

* chore: Update generation configuration at Wed Apr 23 17:13:26 UTC 2025

* chore: generate libraries at Wed Apr 23 17:14:00 UTC 2025

* chore: Update generation configuration at Thu Apr 24 02:28:57 UTC 2025

* chore: manually update generation configuration

* chore: generate libraries at Thu Apr 24 14:52:36 UTC 2025

* chore: update libraries bom version to the latest

* chore: generate libraries at Thu Apr 24 14:58:18 UTC 2025

* chore: remove old kokoro jobs

---------

Co-authored-by: Diego Marquez <[email protected]>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@nbayati
docs: Update README with X.509 feature details (#1790)
fc92a11 
* docs: Update README with X.509 feature details.

* Address the review comments
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-spanner-…
5bbeba5 
…jdbc to v2.23.0 (googleapis#1790)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@gcf-owl-bot
chore: bump urllib3 from 1.26.17 to 1.26.18 in /synthtool/gcp/templat…
1613245 
…es/java_library/.kokoro (#1885) (#1790)

Source-Link: googleapis/synthtool@e4a9d44
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:4875b2142cb4325542ba4f3175a81921c4b2b8256db012b220e3ca9637b34154

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@gcf-owl-bot
chore: bump urllib3 from 1.26.17 to 1.26.18 in /synthtool/gcp/templat…
a0fe73a 
…es/java_library/.kokoro (#1885) (#1790)

Source-Link: googleapis/synthtool@e4a9d44
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:4875b2142cb4325542ba4f3175a81921c4b2b8256db012b220e3ca9637b34154

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 2, 2026
@kevkim-codes
feat: Add additional Firestore query snippets (#1790)
659f3ee 
* firestore sample for multiple inequality

* fix typo

* format code

* change samples to be in own file

* Create maven.yml

* Delete .github/workflows/maven.yml

* change query to lowercase to pass  test case

* fix checkstyle lint error

* update copyright dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbausor michaelbausor Awaiting requested review from michaelbausor

2 more reviewers

@bjwatson bjwatson bjwatson left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shinfan @coveralls @bjwatson @garrettjonesgoogle @googlebot