Removing ServiceRpcT parameterization by garrettjonesgoogle · Pull Request #1759 · googleapis/google-cloud-java

garrettjonesgoogle · 2017-03-16T00:20:36Z

Also:

Moving spi/*Rpc classes to spi/{MAJOR_VERSION}/*Rpc
Renaming DefaultRpc classes to HttpRpc/Grpc*Rpc as appropriate

Note: There are references in google-cloud-examples to Rpc-specific stuff (Only Tuples I think); I will file a separate issue to remove those.

michaelbausor · 2017-03-16T02:42:43Z

I re-read the issue, but I am still not sure why we need to remove the ServiceRpcT parameterization. As an example, currently BigQueryOptions extends ServiceOptions<BigQuery, BigQueryRpc, BigQueryOptions>. The BigQueryRpc interface is independent of http/grpc, even if DefaultBigQueryRpc (now HttpBigQueryRpc) is not.

Sign in to view

 */

-package com.google.cloud.bigquery.spi;
+package com.google.cloud.bigquery.spi.v2;


garrettjonesgoogle · 2017-03-16T18:09:17Z

@michaelbausor , The Rpc interface (e.g. BigQueryRpc) is tied to old-platform vs proto and also the specific major version. When the Rpc class is old-platform, only http 1 is available. My understanding is that the design of using a fully wrapped surface means that old-platform vs proto and major versions shouldn't be exposed.

coveralls · 2017-03-16T19:32:34Z

Changes Unknown when pulling 2461921 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**.

Sign in to view


 /** Factory to create instances of {@code SpannerRpc}. */
-public interface SpannerRpcFactory extends ServiceRpcFactory<SpannerRpc, SpannerOptions> {}
+public interface SpannerRpcFactory extends ServiceRpcFactory<SpannerOptions> {}


Sign in to view

 import com.google.cloud.HttpTransportOptions;
 import com.google.cloud.compute.ComputeException;
 import com.google.cloud.compute.ComputeOptions;
+import com.google.cloud.compute.spi.v1.ComputeRpc;


Sign in to view

 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;

+import com.google.cloud.spanner.spi.v1.WatchdogInterceptor;


Sign in to view


    @Override
-    public ComputeRpc create(ComputeOptions options) {
+    public ServiceRpc create(ComputeOptions options) {


Sign in to view

  }

-  protected BigQueryRpc getBigQueryRpc() {
+  protected BigQueryRpc getBigQueryRpcV2() {


michaelbausor

LGTM, your choice of what to do about nits.

#1759) Co-authored-by: Cindy Peng <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

#1759) Co-authored-by: Cindy Peng <[email protected]>

…v3.36.0 (googleapis#1759)

Also: * Moving spi/*Rpc classes to spi/{MAJOR_VERSION}/*Rpc * Renaming DefaultRpc classes to HttpRpc/Grpc*Rpc as appropriate

#1759)

garrettjonesgoogle added 13 commits March 15, 2017 17:03

Removing ServiceRpcT from Service/ServiceOptions parameterization

f8bd0cc

Rename of BigQuery rpc classes

5f2cb5a

Rename of Storage rpc classes

c7fa1cf

Rename of Compute rpc classes

394390a

Rename of Datastore rpc classes

197c17b

Rename of Dns rpc classes

2991d13

Rename of Logging rpc classes

10e27be

Rename of PubSub rpc classes

c850c8c

Rename of ResourceManager rpc classes

afbfddb

Rename of Spanner rpc classes

c26064c

Rename of Translate rpc classes

5c1a91a

Default*RpcFactory: returning ServiceRpc everywhere

fedeea4

Renaming get*Rpc() to get*Rpc{MV}()

2461921

garrettjonesgoogle requested a review from michaelbausor March 16, 2017 00:20

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2017

michaelbausor reviewed Mar 16, 2017

View reviewed changes

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/BigQueryRpc.java

*/

package com.google.cloud.bigquery.spi;

package com.google.cloud.bigquery.spi.v2;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

michaelbausor reviewed Mar 16, 2017

View reviewed changes

michaelbausor approved these changes Mar 16, 2017

View reviewed changes

nits [ci skip]

a264cb4

garrettjonesgoogle merged commit e2edc3c into googleapis:master Mar 17, 2017

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore: Update generation configuration at Fri Feb 21 02:23:23 UTC 2025 (

5144e7a

#1759) Co-authored-by: Cindy Peng <[email protected]>

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

chore(main): release 1.36.1-SNAPSHOT (#1759)

4340841

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

chore(main): release 1.36.1-SNAPSHOT (#1759)

d49228b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

chore: Update generation configuration at Fri Feb 21 02:23:23 UTC 2025 (

45489d2

#1759) Co-authored-by: Cindy Peng <[email protected]>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

7aa9df6

…v3.36.0 (googleapis#1759)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

Removing ServiceRpcT parameterization (#1759)

a4f097a

Also: * Moving spi/*Rpc classes to spi/{MAJOR_VERSION}/*Rpc * Renaming DefaultRpc classes to HttpRpc/Grpc*Rpc as appropriate

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

Removing ServiceRpcT parameterization (#1759)

0996be9

Also: * Moving spi/*Rpc classes to spi/{MAJOR_VERSION}/*Rpc * Renaming DefaultRpc classes to HttpRpc/Grpc*Rpc as appropriate

meltsufin pushed a commit that referenced this pull request May 2, 2026

chore: Update generation configuration at Tue Jul 23 02:16:49 UTC 2024 (

a9196e7

#1759)

Conversation

garrettjonesgoogle commented Mar 16, 2017

Uh oh!

michaelbausor commented Mar 16, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Mar 16, 2017

Uh oh!

coveralls commented Mar 16, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

michaelbausor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants