Changing the AckReplyConsumer interface#1758
Merged
pongad merged 7 commits intogoogleapis:masterfrom Mar 21, 2017
Merged
Conversation
…on to (googleapis#1645)". Compression is not fully supported in gRPC, can't have it in the library yet. This reverts commit a599972.
…Consumer interface, it really is no useful to be able to set an exception as ack reply, since the result is the same as nack, if we ever require another result then we can just add one more value to the AckReply enum. Also adding a fail-safe catch so if the receiver ever throws an exception we will interpret that as a nack and keep going.
googlebot
added
the
cla: yes
Contributor
|
LGTM from me. @garrettjonesgoogle can +2 |
Contributor
|
LGTM - but why are there no Travis test results here? @davidtorres could you push a PR update to rerun the tests? |
Author
|
Tests are running, travis already passing. Thanks for reviewing. |
Contributor
|
LGTM, thank you! |
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
🤖 I have created a release *beep* *boop* --- ## [2.26.3](https://togithub.com/googleapis/java-datastore/compare/v2.26.2...v2.26.3) (2025-02-21) ### Dependencies * Update dependency com.google.cloud:gapic-libraries-bom to v1.52.0 ([#1747](https://togithub.com/googleapis/java-datastore/issues/1747)) ([592072b](https://togithub.com/googleapis/java-datastore/commit/592072b194706e63a7fd4a6f6230377e8f4b729d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
🤖 I have created a release *beep* *boop* --- ## [2.26.3](https://togithub.com/googleapis/java-datastore/compare/v2.26.2...v2.26.3) (2025-02-21) ### Dependencies * Update dependency com.google.cloud:gapic-libraries-bom to v1.52.0 ([#1747](https://togithub.com/googleapis/java-datastore/issues/1747)) ([c63d4ec](https://togithub.com/googleapis/java-datastore/commit/c63d4ec089dbde8feadf9288dd3f942f9821f017)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@garrettjonesgoogle @pongad I'm changing the interface of AckReplyConsumer because it really does not buy us anything to be able to accept an exception along with the ackreply. It actually makes the interface ambiguous, i.e what does it mean to accept an AckReply and a non null exception. And moreover I'd like to avoid methods in which you can pass null parameters.