Add DatastoreBackupOptions class for BigQuery by shinfan · Pull Request #1757 · googleapis/google-cloud-java

shinfan · 2017-03-15T20:59:20Z

Fixes #552

Sign in to view

-     * all properties. If any named property isn't found in the Cloud Datastore backup, an invalid
-     * error is returned in the job result.
-     */
-    Builder setProjectionFields(List<String> projectionFields);


Sign in to view

          .setFormatOptions(CSV_OPTIONS)
          .setIgnoreUnknownValues(IGNORE_UNKNOWN_VALUES)
          .setMaxBadRecords(MAX_BAD_RECORDS)
-          .setProjectionFields(PROJECTION_FIELDS)


coveralls · 2017-03-16T00:26:26Z

Changes Unknown when pulling e8f9472 on shinfan:master into ** on GoogleCloudPlatform:master**.

shinfan · 2017-03-16T01:29:53Z

PTAL

coveralls · 2017-03-16T03:08:02Z

Changes Unknown when pulling 763ead9 on shinfan:master into ** on GoogleCloudPlatform:master**.

Sign in to view

      this.ignoreUnknownValues = loadConfigurationPb.getIgnoreUnknownValues();
-      this.projectionFields = loadConfigurationPb.getProjectionFields();
+      if (loadConfigurationPb.getProjectionFields() != null) {
+        this.formatOptions = DatastoreBackupOptions.newBuilder()


shinfan · 2017-03-16T19:48:33Z

Two of the tests passed and the others failed due to timeout. I don't think it is caused by this PR.

Sign in to view

+     * If no properties are specified, BigQuery loads all properties. If any named property isn't
+     * found in the Cloud Datastore backup, an invalid error is returned in the job result.
+     */
+    Builder setProjectionFields(List<String> projectionFields) {


Sign in to view

+/**
+ * Google BigQuery options for Cloud Datastore backup.
+ */
+public final class DatastoreBackupOptions extends FormatOptions {


shinfan · 2017-03-17T00:24:55Z

@michaelbausor PTAL

coveralls · 2017-03-17T00:58:29Z

Changes Unknown when pulling 0a76886 on shinfan:master into ** on GoogleCloudPlatform:master**.

michaelbausor · 2017-03-17T16:15:32Z

LGTM

…image test run command (#1757) (#1267) Source-Link: googleapis/synthtool@df311d1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…image test run command (#1757) (#998) Source-Link: googleapis/synthtool@df311d1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…image test run command (#1757) (#972) Source-Link: googleapis/synthtool@df311d1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…image test run command (googleapis#1757) (googleapis#1267) Source-Link: googleapis/synthtool@df311d1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…v6.75.0 (googleapis#1757)

…24.0 (#1757) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.24.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Add DatastoreBackupOptions class for BigQuery

e8f9472

shinfan requested review from garrettjonesgoogle and michaelbausor March 15, 2017 20:59

shinfan added api: bigquery Issues related to the BigQuery API. breaking change labels Mar 15, 2017

michaelbausor reviewed Mar 15, 2017

View reviewed changes

update PR feedback

763ead9

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2017

michaelbausor reviewed Mar 16, 2017

View reviewed changes

update factory method

41ff3e1

michaelbausor reviewed Mar 16, 2017

View reviewed changes

Update

0a76886

shinfan merged commit 20777d3 into googleapis:master Mar 17, 2017

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

chore(main): release 3.21.3-SNAPSHOT (#1757)

b62eec4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026

chore(main): release 3.21.3-SNAPSHOT (googleapis#1757)

5d900b0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

deps: update dependency com.google.cloud:google-cloud-spanner-bom to …

e1b7554

…v6.75.0 (googleapis#1757)

meltsufin pushed a commit that referenced this pull request May 2, 2026

chore(main): release 3.24.1 (#1757)

b141153

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Conversation

shinfan commented Mar 15, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 16, 2017

Uh oh!

shinfan commented Mar 16, 2017

Uh oh!

coveralls commented Mar 16, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Mar 16, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

shinfan commented Mar 17, 2017

Uh oh!

coveralls commented Mar 17, 2017

Uh oh!

michaelbausor commented Mar 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants