Skip to content

Remove deperecated methods from GCE#1753

Merged
shinfan merged 1 commit intogoogleapis:masterfrom
shinfan:master
Mar 15, 2017
Merged

Remove deperecated methods from GCE#1753
shinfan merged 1 commit intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Copy Markdown
Contributor

@shinfan shinfan commented Mar 14, 2017 •
edited
Loading

  • Removed all references of deprecated methods from GCE
  • Fixed a StackOverflow bug in Subnetwork.java where new getter/setters recursively calling themselves

@shinfan shinfan added the api: compute Issues related to the Compute Engine API. label Mar 14, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017
michaelbausor
michaelbausor reviewed Mar 14, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed a random sample, LGTM

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 14, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a scan, LGTM

google-cloud-compute/src/main/java/com/google/cloud/compute/Subnetwork.java

@Override
public Builder setNetwork(NetworkId network) {
return setNetwork(network);

This comment was marked as spam.

Sign in to view

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Mar 14, 2017

I will try to wait for the tests to pass before merge.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Mar 15, 2017

Also fix the spelling in your commit message when you merge.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 15, 2017

Coverage Status

Changes Unknown when pulling 2168795 on shinfan:master into ** on GoogleCloudPlatform:master**.

@shinfan shinfan merged commit fc9f9f7 into googleapis:master Mar 15, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@renovate-bot
deps: update googleapis/sdk-platform-java action to v2.52.0 (#1753)
3dcf86a
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.21.2 (#1754)
cae733e 
🤖 I have created a release *beep* *boop*
---


## [3.21.2](https://togithub.com/googleapis/java-logging/compare/v3.21.1...v3.21.2) (2025-01-29)


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1755](https://togithub.com/googleapis/java-logging/issues/1755)) ([d404381](https://togithub.com/googleapis/java-logging/commit/d4043815246423efe542356dc50ba663092b8df0))
* Update dependency io.opentelemetry:opentelemetry-bom to v1.46.0 ([#1747](https://togithub.com/googleapis/java-logging/issues/1747)) ([5ef2853](https://togithub.com/googleapis/java-logging/commit/5ef285387d63b79bff7e43b233c7f9770f378dba))
* Update googleapis/sdk-platform-java action to v2.52.0 ([#1753](https://togithub.com/googleapis/java-logging/issues/1753)) ([3dcf86a](https://togithub.com/googleapis/java-logging/commit/3dcf86adc3e1ef3d5866cd043149808601c213b8))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@release-please
chore(main): release 1.36.0 (#1753)
153fa4a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@renovate-bot
deps: update googleapis/sdk-platform-java action to v2.52.0 (googleap…
736b9e6 
…is#1753)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@release-please
chore(main): release 3.21.2 (googleapis#1754)
09ffbcf 
🤖 I have created a release *beep* *boop*
---


## [3.21.2](https://togithub.com/googleapis/java-logging/compare/v3.21.1...v3.21.2) (2025-01-29)


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([googleapis#1755](https://togithub.com/googleapis/java-logging/issues/1755)) ([3baecab](https://togithub.com/googleapis/java-logging/commit/3baecab38344cb952c55e2886b75b2be85057bd9))
* Update dependency io.opentelemetry:opentelemetry-bom to v1.46.0 ([googleapis#1747](https://togithub.com/googleapis/java-logging/issues/1747)) ([13547b7](https://togithub.com/googleapis/java-logging/commit/13547b77da7f9af702e8240571edc6480f8176c3))
* Update googleapis/sdk-platform-java action to v2.52.0 ([googleapis#1753](https://togithub.com/googleapis/java-logging/issues/1753)) ([736b9e6](https://togithub.com/googleapis/java-logging/commit/736b9e6c75bde3ac3a9a2a3b4621a8345c65c7dc))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@release-please
chore(main): release 1.36.0 (#1753)
2df5a72 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud.samples:shared-config…
b580e8a 
…uration to v1.2.2 (googleapis#1753)
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@release-please
chore(main): release 0.128.14 (#1753)
3045aaa 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@release-please
chore(main): release 0.128.14 (#1753)
ee06025 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@michaelbausor michaelbausor michaelbausor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shinfan @garrettjonesgoogle @coveralls @michaelbausor @googlebot