GAX rename: RpcFuture -> ApiFuture#1690
Merged
garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom Mar 7, 2017
Merged
GAX rename: RpcFuture -> ApiFuture#1690garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom
garrettjonesgoogle merged 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
garrettjonesgoogle
changed the title
vam-google
reviewed
Mar 6, 2017
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
Please update the PubSub README.md as it references RpcFuture. Also please don't forget to update generated documentation.
|
|
||
| @Override | ||
| protected ByteString getByteString() { | ||
| public ByteString getByteString() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
garrettjonesgoogle
force-pushed
the
master
branch
from
582ee62 to
d63ba68
Compare
Contributor
Author
|
Feedback addressed, PTAL |
vam-google
approved these changes
Mar 7, 2017
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM (also please consider adressing those codacy-bot auto-comments first, even though they are not related to your changes).
Contributor
Author
|
As for the codacy-bot comments, it is wrong in this case. We specifically want println statements because it is just example code. |
garrettjonesgoogle
changed the title
|
Changes Unknown when pulling 767ede9 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**. |
|
Changes Unknown when pulling 767ede9 on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**. |
rybosome
pushed a commit
to rybosome/google-cloud-java
that referenced
this pull request
Mar 9, 2017
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
…e to v2.25.1 (#1690) Co-authored-by: Cindy Peng <[email protected]>
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT deps: update dependency com.google.cloud:sdk-platform-java-config to v3.53.0 Closes #1689 END_NESTED_COMMIT BEGIN_NESTED_COMMIT deps: update dependency com.google.cloud:google-cloud-storage to v2.59.0 Closes #1690 END_NESTED_COMMIT END_COMMIT_OVERRIDE --------- Co-authored-by: Mend Renovate <[email protected]>
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT deps: update dependency com.google.cloud:sdk-platform-java-config to v3.53.0 Closes #1689 END_NESTED_COMMIT BEGIN_NESTED_COMMIT deps: update dependency com.google.cloud:google-cloud-storage to v2.59.0 Closes #1690 END_NESTED_COMMIT END_COMMIT_OVERRIDE --------- Co-authored-by: Mend Renovate <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.