add test for Publisher and Subscriber snippets#1658
Merged
pongad merged 1 commit intogoogleapis:masterfrom Feb 28, 2017
pongad:snippet-test
Merged
add test for Publisher and Subscriber snippets#1658pongad merged 1 commit intogoogleapis:masterfrom pongad:snippet-test
pongad merged 1 commit intogoogleapis:masterfrom
pongad:snippet-test
Conversation
googlebot
added
the
cla: yes
|
Changes Unknown when pulling d84ae75 on pongad:snippet-test into ** on GoogleCloudPlatform:master**. |
lesv
approved these changes
Feb 24, 2017
Contributor
|
Of course, you need to fix what ever is making Travis unhappy. |
lesv
reviewed
Feb 24, 2017
| @Override | ||
| public void run() { | ||
| try { | ||
| received.set(queue.poll(10, TimeUnit.MINUTES)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@lesv The Travis failure seems to be coming from Spanner and unrelated to this change. Nearest I can tell, it might be from temporary connection issue while downloading Maven packages. I reran to make sure. |
Contributor
|
LGTM from me, ping to @garrettjonesgoogle and @jabubake |
Contributor
|
LGTM |
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
`devoncarew` is a Googler who is contributing to Rust SDK.
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
`devoncarew` is a Googler who is contributing to Rust SDK.
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…jdbc to v2.19.4 (googleapis#1658) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner-jdbc](https://togithub.com/googleapis/java-spanner-jdbc) | `2.19.3` -> `2.19.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-spanner-jdbc (com.google.cloud:google-cloud-spanner-jdbc)</summary> ### [`v2.19.4`](https://togithub.com/googleapis/java-spanner-jdbc/releases/tag/v2.19.4) [Compare Source](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.19.3...v2.19.4) ##### Dependencies - Update dependency org.springframework.data:spring-data-bom to v2024.0.1 ([#&googleapis#8203;1645](https://togithub.com/googleapis/java-spanner-jdbc/issues/1645)) ([b76e435](https://togithub.com/googleapis/java-spanner-jdbc/commit/b76e435538a6faf3f38da463ca05f5c5e9238705)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-spanner-jdbc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
](https://renovatebot.com){kind=link}
…o v1.123.18 (#1658) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.18 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
…o v1.123.18 (#1658) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.18 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test code isn't as clear as I hoped, but I'm not sure how to simplify it without complicating the samples.
FYI @jabubake