Skip to content

rename MessagesProcessor to MessageDispatcher#1548

Merged
pongad merged 5 commits intogoogleapis:pubsub-hpfrom
pongad:mv-dispatcher
Jan 20, 2017
Merged

rename MessagesProcessor to MessageDispatcher#1548
pongad merged 5 commits intogoogleapis:pubsub-hpfrom
pongad:mv-dispatcher

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Jan 19, 2017 •
edited
Loading

Fixes #1546

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2017
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2017

Coverage Status

Changes Unknown when pulling 8048d02 on pongad:mv-dispatcher into ** on GoogleCloudPlatform:pubsub-hp**.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2017

Coverage Status

Changes Unknown when pulling 8048d02 on pongad:mv-dispatcher into ** on GoogleCloudPlatform:pubsub-hp**.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2017

Coverage Status

Coverage remained the same at 83.158% when pulling 5764d49 on pongad:mv-dispatcher into d70aaf7 on GoogleCloudPlatform:pubsub-hp.

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 19, 2017
View reviewed changes
Comment thread ...e-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java Outdated
import com.google.cloud.Clock;
import com.google.cloud.pubsub.spi.v1.MessagesProcessor.AcksProcessor;
import com.google.cloud.pubsub.spi.v1.MessagesProcessor.PendingModifyAckDeadline;
import com.google.cloud.pubsub.spi.v1.MessageDispatcher.AcksProcessor;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Jan 19, 2017

LGTM

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 19, 2017
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java Outdated
private final Duration ackExpirationPadding;
private final MessageReceiver receiver;
private final AcksProcessor acksProcessor;
private final AckProcessor acksProcessor;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jan 19, 2017

@garrettjonesgoogle I preemptively apologize if there are more I didn't catch.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2017

Coverage Status

Coverage decreased (-0.007%) to 83.15% when pulling 2f6c442 on pongad:mv-dispatcher into d70aaf7 on GoogleCloudPlatform:pubsub-hp.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2017

Coverage Status

Coverage decreased (-0.007%) to 83.15% when pulling 2f6c442 on pongad:mv-dispatcher into d70aaf7 on GoogleCloudPlatform:pubsub-hp.

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 19, 2017
View reviewed changes
Comment thread ...cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java Outdated
private final String subscription;
private final ScheduledExecutorService executor;
private final MessagesProcessor messagesProcessor;
private final MessageDispatcher messagesProcessor;

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jan 19, 2017

@garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Jan 20, 2017

LGTM

@pongad pongad merged commit 0550871 into googleapis:pubsub-hp Jan 20, 2017
@pongad pongad deleted the mv-dispatcher branch January 20, 2017 00:36
@pongad pongad mentioned this pull request Jan 20, 2017
Closed
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@suztomo @gcf-owl-bot
ci: sample build in Cloud Build (#1548)
3035980 
* ci: sample build in Cloud Build

* trigger build

* trigger build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@renovate-bot
deps: update dependency com.google.guava:guava-testlib to v33.3.0-jre (…
18ba37f 
…#1548)
suztomo added a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@suztomo @gcf-owl-bot
ci: sample build in Cloud Build (googleapis#1548)
5f54b30 
* ci: sample build in Cloud Build

* trigger build

* trigger build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update actions/github-script action to v7 (googleapis#1548)
0f8dd26
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-nio to v…
7d54709 
…0.127.32 (#1548)
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-nio to v…
9ae6b04 
…0.127.32 (#1548)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot @gcf-owl-bot
deps: update dependency org.graalvm.buildtools:native-maven-plugin to…
42957f8 
… v0.9.21 (#1548)

* deps: update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot @gcf-owl-bot
deps: update dependency org.graalvm.buildtools:native-maven-plugin to…
3288a7b 
… v0.9.21 (#1548)

* deps: update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @coveralls @garrettjonesgoogle @googlebot