Skip to content

delete pull-related methods from PubSub#1487

Merged
pongad merged 7 commits intogoogleapis:pubsub-hpfrom
pongad:del-pull
Dec 22, 2016
Merged

delete pull-related methods from PubSub#1487
pongad merged 7 commits intogoogleapis:pubsub-hpfrom
pongad:del-pull

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Dec 21, 2016

Instead, provide a way to create the Subscriber object.

cc @davidtorres

@pongad
delete pull-related methods from PubSub
135a4b2 
Instead, provide a way to create the Subscriber object.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2016
davidtorres
davidtorres reviewed Dec 21, 2016
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java Outdated
}

@Override
public void modifyAckDeadline(String subscription, int deadline, TimeUnit unit, String ackId,

This comment was marked as spam.

Sign in to view

pongad
pongad commented Dec 21, 2016
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java
.maxQueuedCallbacks(MAX_QUEUED_CALLBACKS.getInteger(optionMap))
.executorFactory(EXECUTOR_FACTORY.getExecutorFactory(optionMap))
public Subscriber subscriber(SubscriptionInfo subscription, Subscriber.MessageReceiver receiver) {
// TODO(pongad): Provide a way to pass in the rest of the options.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 21, 2016

Coverage Status

Changes Unknown when pulling 9df40ba on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Dec 21, 2016

@davidtorres PTAL

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 21, 2016

Coverage Status

Changes Unknown when pulling 2239a50 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 21, 2016

Coverage Status

Changes Unknown when pulling 2239a50 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Dec 21, 2016

A couple high-level things:

  • We need to write down in our TO DO list to write new samples that replace the deleted ones here (in spirit)
  • Does our new code have the same level of test coverage as the code that's being deleted?
  • We might want to write down some migration details for anyone using the library currently. Could you draft up a list of equivalents to each method on the main surface that you're deleting?

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Dec 22, 2016

@garrettjonesgoogle

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Dec 22, 2016

Add a TODO to settle the issue of executors & channels. Otherwise LGTM.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 22, 2016

Coverage Status

Changes Unknown when pulling 6cd3804 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

@pongad pongad mentioned this pull request Dec 22, 2016
Closed
6 tasks
@pongad pongad merged commit 994479f into googleapis:pubsub-hp Dec 22, 2016
@pongad pongad deleted the del-pull branch December 22, 2016 01:17
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 22, 2016

Coverage Status

Changes Unknown when pulling 46bf12f on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.15.15-SNAPSHOT (#1487)
bbb7a0f 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@release-please
chore(main): release 3.15.15-SNAPSHOT (googleapis#1487)
779b129 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-spanner-bom to …
e22529c 
…v6.58.0 (googleapis#1487)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 2.15.4 (googleapis#1490)
bc054b1 
🤖 I have created a release *beep* *boop*
---


## [2.15.4](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.15.3...v2.15.4) (2024-02-15)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.25.0 ([googleapis#1492](https://togithub.com/googleapis/java-spanner-jdbc/issues/1492)) ([04b3ffb](https://togithub.com/googleapis/java-spanner-jdbc/commit/04b3ffb566a4d3a5390f0de32f8cb4f8ab9eae56))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.58.0 ([googleapis#1487](https://togithub.com/googleapis/java-spanner-jdbc/issues/1487)) ([e22529c](https://togithub.com/googleapis/java-spanner-jdbc/commit/e22529cbf4305ab1c7ad64dbf64cc7350df6f579))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.59.0 ([googleapis#1495](https://togithub.com/googleapis/java-spanner-jdbc/issues/1495)) ([3df31cc](https://togithub.com/googleapis/java-spanner-jdbc/commit/3df31cc9d73cedefae9d0dbf6f77739d85c55961))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.25.0 ([googleapis#1493](https://togithub.com/googleapis/java-spanner-jdbc/issues/1493)) ([834cc65](https://togithub.com/googleapis/java-spanner-jdbc/commit/834cc654394ed3940978f1e7c5c7b372405b6493))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@release-please
chore(main): release 0.127.25 (#1487)
7c3fa88 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@release-please
chore(main): release 0.127.25 (#1487)
57bd7e3 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-javadoc…
0729603 
…-plugin to v3.5.0 (#1487)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.1` -> `3.5.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/compatibility-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/confidence-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEyNS4xIn0=-->
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-javadoc…
c2ecbe8 
…-plugin to v3.5.0 (#1487)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.1` -> `3.5.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/compatibility-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/confidence-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEyNS4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@davidtorres davidtorres davidtorres left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pongad @coveralls @garrettjonesgoogle @davidtorres @googlebot