Make defaultLibraryVersion() more robust by shinfan · Pull Request #1436 · googleapis/google-cloud-java

shinfan · 2016-11-30T23:51:31Z

defaultLibraryVersion() now reads version from pom.properties

Fixes #1434
Tested manually.

sai-pullabhotla · 2016-12-01T00:43:18Z

I don't have a whole lot of background on this, but I'm curious - why can't we use something as simple as -

ServiceOptions.class.getPackage().getImplementationVersion();

That should do the work of getting the implementation version from Jar's metadata.

shinfan · 2016-12-01T00:48:37Z

@sai-pullabhotla I tried this approach but it did not work for me (the method simply returns null).

sai-pullabhotla · 2016-12-01T01:11:40Z

@shinfan - as long as the class is loaded from JAR and JAR has manifest with the Implementation-Version defined, it should work. Below is what I get:

Package pack = ServiceOptions.class.getPackage();
System.out.println("Impl Title: " + pack.getImplementationTitle());
System.out.println("Impl Version: " + pack.getImplementationVersion());
System.out.println("Spec Title: " + pack.getSpecificationTitle());
System.out.println("Spec Version: " + pack.getSpecificationVersion());

Output

Impl Title: Google Cloud Core
Impl Version: 0.7.0
Spec Title: Google Cloud Core
Spec Version: 0.7.0

coveralls · 2016-12-01T02:41:43Z

Coverage decreased (-0.01%) to 84.33% when pulling e21fc25 on shinfan:master into 5dfb904 on GoogleCloudPlatform:master.

Sign in to view

+            properties.load(inputStream);
+            return properties.getProperty(META_VERSION_KEY, "");
+        }
+    } catch (Exception e) {


Sign in to view

    return version;
  }
+
+  private static String getMavenVersion() {


garrettjonesgoogle · 2016-12-01T18:27:29Z

LIBRARY_NAME should be changed to "google-cloud-java". There are also a couple comments that reference the old name ("gcloud-java").

shinfan · 2016-12-01T20:15:19Z

@sai-pullabhotla As I said, the method did not work under my environment and it returned null. If it happens to me it may happen to other users. My best guess is that my maven does not insert the correct manifest data into the JAR.

shinfan · 2016-12-01T20:42:41Z

@garrettjonesgoogle PTAL

Sign in to view

-          version = manifestAttributes.getValue(MANIFEST_VERSION_KEY);
+    String version = getPomVersion();
+    if (version == null) {
+      try {


garrettjonesgoogle · 2016-12-01T21:58:59Z

LGTM after Travis passes

shinfan · 2016-12-01T22:31:34Z

Travis passed for oraclejdk7/8 and openjdk. There is one "no_language_set" pending for 30 mins.
AppVeyor CI failed but I believe it is caused by flakiness. I will go ahead and merge if no objection @garrettjonesgoogle

garrettjonesgoogle · 2016-12-01T22:33:01Z

The "no_language_set" one is for Mac. I have often seen it take longer. I have no concerns about your CL on mac so go ahead and merge it.

coveralls · 2016-12-01T23:12:35Z

Coverage decreased (-0.04%) to 84.3% when pulling 2ff6851 on shinfan:master into 5dfb904 on GoogleCloudPlatform:master.

coveralls · 2016-12-02T09:42:01Z

Coverage decreased (-0.04%) to 84.303% when pulling c3077da on shinfan:master into 5dfb904 on GoogleCloudPlatform:master.

mziccard · 2016-12-02T09:55:11Z

LIBRARY_NAME should be changed to "google-cloud-java". There are also a couple comments that reference the old name ("gcloud-java").

@garrettjonesgoogle did you check this with @omaray and @jgeewax? Last time we discussed this (~2months ago) it was suggested to stick to gcloud-java for the time being.

I feel like a creep when I step in like this :)

garrettjonesgoogle · 2016-12-02T15:56:43Z

No, your feedback is always welcome :-)

We have agreed internally to change all languages to google-cloud-java for this value.

garrettjonesgoogle · 2016-12-02T21:28:58Z

I checked again internally and I was wrong - this needs to be changed back to gcloud-java. @shinfan , could you fix that up? Sorry for the churn.

shinfan · 2016-12-05T03:25:53Z

Acknowledged. Will do.

* chore(deps): Update gapic-generator-java to 2.26.0 PiperOrigin-RevId: 567624307 Source-Link: googleapis/googleapis@2ecf4de Source-Link: https://github.com/googleapis/googleapis-gen/commit/a5cfbd9a05b3a134e92886114db776fb33cec9f2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTVjZmJkOWEwNWIzYTEzNGU5Mjg4NjExNGRiNzc2ZmIzM2NlYzlmMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…1436) * Doc: Add more explanation and examples for logbackBatchingSettings * fix comments

…39.0 (#1436) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.39.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore(deps): Update gapic-generator-java to 2.26.0 PiperOrigin-RevId: 567624307 Source-Link: googleapis/googleapis@2ecf4de Source-Link: https://github.com/googleapis/googleapis-gen/commit/a5cfbd9a05b3a134e92886114db776fb33cec9f2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTVjZmJkOWEwNWIzYTEzNGU5Mjg4NjExNGRiNzc2ZmIzM2NlYzlmMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…1436) * Doc: Add more explanation and examples for logbackBatchingSettings * fix comments

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…43.0 (#1436)

…cies to v3.1.0 (#1436) * deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 * fix: update the pubsub fake executor to cancel a pending callables future when cancelled Co-authored-by: hannahrogers-google <[email protected]>

Make defaultLibraryVersion() more robust

e21fc25

shinfan assigned garrettjonesgoogle Nov 30, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2016

garrettjonesgoogle reviewed Dec 1, 2016

View reviewed changes

Fix PR comments

1b3662f

Fix unit test

c3077da

garrettjonesgoogle reviewed Dec 1, 2016

View reviewed changes

update

2ff6851

shinfan merged commit 15e2e2d into googleapis:master Dec 1, 2016

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

Doc: Add more explanation and examples for logbackBatchingSettings (#…

bdbb0f7

…1436) * Doc: Add more explanation and examples for logbackBatchingSettings * fix comments

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

Doc: Add more explanation and examples for logbackBatchingSettings (#…

67e21fd

…1436) * Doc: Add more explanation and examples for logbackBatchingSettings * fix comments

suztomo pushed a commit that referenced this pull request Mar 30, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

282de97

…43.0 (#1436)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

97a827d

…43.0 (#1436)

Conversation

shinfan commented Nov 30, 2016

Uh oh!

sai-pullabhotla commented Dec 1, 2016

Uh oh!

shinfan commented Dec 1, 2016

Uh oh!

sai-pullabhotla commented Dec 1, 2016

Output

Uh oh!

coveralls commented Dec 1, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Dec 1, 2016

Uh oh!

shinfan commented Dec 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shinfan commented Dec 1, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Dec 1, 2016

Uh oh!

shinfan commented Dec 1, 2016

Uh oh!

garrettjonesgoogle commented Dec 1, 2016

Uh oh!

coveralls commented Dec 1, 2016

Uh oh!

coveralls commented Dec 2, 2016

Uh oh!

mziccard commented Dec 2, 2016

Uh oh!

garrettjonesgoogle commented Dec 2, 2016

Uh oh!

garrettjonesgoogle commented Dec 2, 2016

Uh oh!

shinfan commented Dec 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shinfan commented Dec 1, 2016 •

edited

Loading