Skip to content

Using fake clock in AckDeadlineRenewerTest#1413

Merged
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
garrettjonesgoogle:master
Nov 21, 2016
Merged

Using fake clock in AckDeadlineRenewerTest#1413
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle commented Nov 18, 2016

This reduces the running time of the test from 3-4 minutes
down to 0.03 seconds.

@garrettjonesgoogle
Using fake clock in AckDeadlineRenewerTest
e85f01d 
This reduces the running time of the test from 3-4 minutes
down to 0.03 seconds.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2016
@garrettjonesgoogle
Copy link
Copy Markdown
Contributor Author

garrettjonesgoogle commented Nov 18, 2016

/cc @michaelbausor

michaelbausor
michaelbausor reviewed Nov 18, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment plus codacy issues

Comment thread google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/FakeScheduledExecutorService.java
}

@Override
public Object get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 19, 2016

Coverage Status

Coverage remained the same at 84.21% when pulling 6445220 on garrettjonesgoogle:master into 3f3e7c0 on GoogleCloudPlatform:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 19, 2016

Coverage Status

Coverage remained the same at 84.21% when pulling 6445220 on garrettjonesgoogle:master into 3f3e7c0 on GoogleCloudPlatform:master.

@garrettjonesgoogle garrettjonesgoogle merged commit 1a8a438 into googleapis:master Nov 21, 2016
github-actions Bot pushed a commit that referenced this pull request Jul 14, 2022
@gcf-owl-bot
chore: fix minor typos in README and pom templates (#1479) (#1413)
1641a5c 
Source-Link: googleapis/synthtool@18d4e9b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.15.8 (#1413)
d611a09 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
4b70872 
…51.0 (#1413)
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@kolea2
test(refactor): move aggregation tests into ITDatastoreTest (#1413)
9f55f65
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@renovate-bot
chore(deps): update dependency com.google.errorprone:error_prone_anno…
34e0ac2 
…tations to v2.28.0 (#1413)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@release-please
chore(main): release 3.15.8 (googleapis#1413)
85ed746 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@renovate-bot
chore(deps): update dependency com.google.errorprone:error_prone_anno…
ea59bbd 
…tations to v2.28.0 (#1413)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 2.14.4-SNAPSHOT (googleapis#1413)
dc10e39 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
deps: update dependency com.google.guava:guava to v33.2.1-android (#1413
7078efa 
)
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
deps: update dependency com.google.guava:guava to v33.2.1-android (#1413
4ee1fc6 
)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
deps: update dependency org.graalvm.buildtools:junit-platform-native …
b3fb828 
…to v0.9.18 (#1413)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@release-please
chore(main): release 1.121.1 (#1415)
2264419 
🤖 I have created a release *beep* *boop*
---


## [1.121.1](https://togithub.com/googleapis/java-pubsub/compare/v1.121.0...v1.121.1) (2022-11-21)


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.18.0 ([#1375](https://togithub.com/googleapis/java-pubsub/issues/1375)) ([b6ada4e](https://togithub.com/googleapis/java-pubsub/commit/b6ada4e06397d785b6747bd989fe6cd9d6e76801))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.19.1 ([#1416](https://togithub.com/googleapis/java-pubsub/issues/1416)) ([e140a49](https://togithub.com/googleapis/java-pubsub/commit/e140a4975a5bff4c73254784409f4f3dda27db09))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#1413](https://togithub.com/googleapis/java-pubsub/issues/1413)) ([b3fb828](https://togithub.com/googleapis/java-pubsub/commit/b3fb828480f491e4275adf0b6367aeb51ac0569e))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#1414](https://togithub.com/googleapis/java-pubsub/issues/1414)) ([74d2dc3](https://togithub.com/googleapis/java-pubsub/commit/74d2dc3329f6d4e33c977fa1e73df1aca278b9b3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
deps: update dependency org.graalvm.buildtools:junit-platform-native …
3c08dae 
…to v0.9.18 (#1413)
meltsufin pushed a commit that referenced this pull request May 1, 2026
@release-please
chore(main): release 1.121.1 (#1415)
a66dd65 
🤖 I have created a release *beep* *boop*
---


## [1.121.1](https://togithub.com/googleapis/java-pubsub/compare/v1.121.0...v1.121.1) (2022-11-21)


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.18.0 ([#1375](https://togithub.com/googleapis/java-pubsub/issues/1375)) ([1470aca](https://togithub.com/googleapis/java-pubsub/commit/1470aca5fc1793b87bc4b39a99ddc526616234c9))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.19.1 ([#1416](https://togithub.com/googleapis/java-pubsub/issues/1416)) ([f05454e](https://togithub.com/googleapis/java-pubsub/commit/f05454e972171ce9535c7a38ae86f77049504c5b))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#1413](https://togithub.com/googleapis/java-pubsub/issues/1413)) ([3c08dae](https://togithub.com/googleapis/java-pubsub/commit/3c08daeea87633f7f9266b5c302da655d4366a38))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#1414](https://togithub.com/googleapis/java-pubsub/issues/1414)) ([adbb31d](https://togithub.com/googleapis/java-pubsub/commit/adbb31d44ff81e862c8d473aee5028bc445447a9))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michaelbausor michaelbausor michaelbausor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrettjonesgoogle @coveralls @michaelbausor @googlebot