Skip to content

Un-shade javax#1362

Merged
mziccard merged 1 commit intogoogleapis:masterfrom
jean-philippe-martin:nio_unshade_javax
Nov 3, 2016
Merged

Un-shade javax#1362
mziccard merged 1 commit intogoogleapis:masterfrom
jean-philippe-martin:nio_unshade_javax

Conversation

@jean-philippe-martin
Copy link
Copy Markdown

Shading javax was a mistake.

In addition we probably shouldn't be shading "provided" dependencies since those aren't included in the jar.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2016
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 83.896% when pulling 848d810 on jean-philippe-martin:nio_unshade_javax into a963ef4 on GoogleCloudPlatform:master.

@mziccard mziccard merged commit a70747c into googleapis:master Nov 3, 2016
@jean-philippe-martin jean-philippe-martin deleted the nio_unshade_javax branch November 4, 2016 16:58
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
…0.1 (#1362)

* deps: update dependency com.google.cloud:google-cloud-logging to v3.20.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
* docs: adds readme for supplier based external account credentials

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* addressing review

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>

* clean up workforce docs

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>

* Adding audience documentation for workload

---------

Co-authored-by: Leo <[email protected]>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
* docs: adds readme for supplier based external account credentials

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* Update README.md

Co-authored-by: Leo <[email protected]>

* addressing review

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>

* clean up workforce docs

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <[email protected]>

* Adding audience documentation for workload

---------

Co-authored-by: Leo <[email protected]>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants