Add integration tests and remote test helper for Datastore by mziccard · Pull Request #1226 · googleapis/google-cloud-java

mziccard · 2016-09-06T14:25:57Z

No description provided.

coveralls · 2016-09-06T15:02:21Z

Coverage decreased (-0.06%) to 85.142% when pulling e23ddbf on mziccard:datastore-its into 8cf6a66 on GoogleCloudPlatform:master.

coveralls · 2016-09-13T13:04:26Z

Coverage decreased (-0.06%) to 84.824% when pulling 72e0d3a on mziccard:datastore-its into 9c840d6 on GoogleCloudPlatform:master.

mziccard · 2016-09-13T16:54:08Z

/cc @lesv

lesv · 2016-09-13T17:55:44Z

LGTM - However, while in practice, this shouldn't happen, if you were to run this against the Datastore Emulator, you would find that datastore can be flakey. (as consistency is by default 0.9) I don't know if you'd want to put in code to address this, but I thought I'd mention it. (Note - I have seen this in production as well, but it's been a while).

mziccard · 2016-09-14T15:14:18Z

you would find that datastore can be flakey

This is a good point. Queries can be eventually consistent in datastore, I'll add some come to handle such cases.

…e queries

mziccard · 2016-09-26T13:26:19Z

/cc @lesv I updated tests to handle query's eventual consistency.

coveralls · 2016-09-26T13:50:08Z

Coverage decreased (-0.06%) to 84.545% when pulling 199bd61 on mziccard:datastore-its into f50a31f on GoogleCloudPlatform:master.

lesv

Timeouts for tests of eventual consistency seems like a good idea, 65 or 129 seconds seems good for our purposes. (Though I've heard, but can't find documentation for longer times).

My ask to move the asserts probably isn't required for this scenario as crashing is a good thing here.

Sign in to view

+    assertNull(list.get(0));
+    assertEquals(entity2, list.get(1));
+    assertEquals(ENTITY3, list.get(2));
+    assertEquals(3, list.size());


Sign in to view

+    }
+
+    try {
+      transaction.rollback();


Sign in to view

+      transaction.commit();
+      fail("Expecting a failure");
+    } catch (DatastoreException ex) {
+      // expected to fail


Sign in to view

+      transaction.rollback();
+      fail("Expecting a failure");
+    } catch (DatastoreException ex) {
+      // expected to fail


Sign in to view

+    }
+  }
+
+  @Test


Sign in to view

+    assertEquals(entity4, entities.get(3));
+    assertEquals(entity5, entities.get(4));
+    assertEquals(entity6, entities.get(5));
+    assertEquals(6, entities.size());


Sign in to view

+    assertEquals(6, entities.size());
+  }
+
+  @Test


Sign in to view

+    assertFalse(keyProjectionResult.hasNext());
+  }
+
+  @Test


Sign in to view

+    assertFalse(results3.hasNext());
+  }
+
+  @Test


lesv · 2016-09-26T20:45:07Z

PTAL

coveralls · 2016-09-27T10:42:12Z

Coverage decreased (-0.06%) to 84.547% when pulling 0ee880f on mziccard:datastore-its into f50a31f on GoogleCloudPlatform:master.

lesv · 2016-09-27T16:36:13Z

LGTM

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…28.0 (#1226) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.28.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…cies to v3.19.0 (#1226)

* chore: Update dependabot.yml Source-Link: https://togithub.com/googleapis/synthtool/commit/9ad18b66e75ca08d6a7779f56c7ee0595d3e1203 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:c33bd13e1eab022b0499a3afbfb4b93ae10cb8ad89d8203a6343a88b1b78400f

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore: Update dependabot.yml Source-Link: https://togithub.com/googleapis/synthtool/commit/9ad18b66e75ca08d6a7779f56c7ee0595d3e1203 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:c33bd13e1eab022b0499a3afbfb4b93ae10cb8ad89d8203a6343a88b1b78400f

…14.0 (googleapis#1226)

* build(deps): bump certifi from 2023.5.7 to 2023.7.22 in /.kokoro Bumps [certifi](https://github.com/certifi/python-certifi) from 2023.5.7 to 2023.7.22. - [Commits](certifi/python-certifi@2023.05.07...2023.07.22) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…cies to v3.0.1 (#1226) * deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.120.9](googleapis/java-pubsub@v1.120.8...v1.120.9) (2022-08-03) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1227](googleapis/java-pubsub#1227)) ([e967b2c](googleapis/java-pubsub@e967b2c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#1226](googleapis/java-pubsub#1226)) ([8fab566](googleapis/java-pubsub@8fab566)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…cies to v3.0.1 (#1226) * deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.120.9](googleapis/java-pubsub@v1.120.8...v1.120.9) (2022-08-03) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1227](googleapis/java-pubsub#1227)) ([52fe226](googleapis/java-pubsub@52fe226)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#1226](googleapis/java-pubsub#1226)) ([9be14bf](googleapis/java-pubsub@9be14bf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added api: datastore Issues related to the Datastore API. testing labels Sep 6, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2016

mziccard force-pushed the datastore-its branch from e23ddbf to 72e0d3a Compare September 13, 2016 12:44

mziccard added 2 commits September 26, 2016 14:56

Add integration tests and remote test helper for Datastore

cfc0035

Add retry logic to integration tests for eventual consistent datastor…

199bd61

…e queries

mziccard force-pushed the datastore-its branch from 72e0d3a to 199bd61 Compare September 26, 2016 13:16

lesv suggested changes Sep 26, 2016

View reviewed changes

Add timeout to Datastore ITs and verify exceptions

0ee880f

lesv approved these changes Sep 27, 2016

View reviewed changes

mziccard merged commit 0e61bd3 into googleapis:master Sep 28, 2016

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

deps: update dependency com.google.cloud:google-cloud-shared-dependen…

970ac96

…cies to v3.19.0 (#1226)

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

f42e782

…14.0 (googleapis#1226)

+                  }
+                }
+                @Test

Conversation

mziccard commented Sep 6, 2016

Uh oh!

coveralls commented Sep 6, 2016

Uh oh!

coveralls commented Sep 13, 2016

Uh oh!

mziccard commented Sep 13, 2016

Uh oh!

lesv commented Sep 13, 2016

Uh oh!

mziccard commented Sep 14, 2016

Uh oh!

mziccard commented Sep 26, 2016

Uh oh!

coveralls commented Sep 26, 2016

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lesv commented Sep 26, 2016

Uh oh!

coveralls commented Sep 27, 2016

Uh oh!

lesv commented Sep 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants