Skip to content

ci: fix existing-versions-check for SNAPSHOT pull requests#11512

Merged
suztomo merged 1 commit intomainfrom
fix_snapshot_check
Mar 26, 2025
Merged

ci: fix existing-versions-check for SNAPSHOT pull requests#11512
suztomo merged 1 commit intomainfrom
fix_snapshot_check

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Mar 26, 2025

b/406479409

Before this fix, the Release Please pull requests that moves non-SNAPSHOT
versions to SNAPSHOT versions have false positive check failure.

When Release Please switches non-SNAPSHOT versions to SNAPSHOT versions,
this check should be skipped. Note that the "autorelease: snapshot" label
was added after the pull request is created.

b/406479409

Before this fix, the Release Please pull requests that moves non-SNAPSHOT
versions to SNAPSHOT versions have false positive check failure.

When Release Please switches non-SNAPSHOT versions to SNAPSHOT versions,
this check should be skipped. Note that the "autorelease: snapshot" label
was added after the pull request is created.
@suztomo suztomo requested a review from a team March 26, 2025 14:53
@suztomo suztomo enabled auto-merge (squash) March 26, 2025 15:13
@suztomo suztomo merged commit 40ca7a8 into main Mar 26, 2025
28 of 29 checks passed
@suztomo suztomo deleted the fix_snapshot_check branch March 26, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants