Skip to content

Change pubsub endpoint from pubsub-experimental to pubsub#1149

Merged
aozarov merged 1 commit intogoogleapis:masterfrom
mziccard:fix-pubsub-endpoint
Aug 10, 2016
Merged

Change pubsub endpoint from pubsub-experimental to pubsub#1149
aozarov merged 1 commit intogoogleapis:masterfrom
mziccard:fix-pubsub-endpoint

Conversation

@mziccard
Copy link
Contributor

@mziccard mziccard commented Aug 10, 2016 •
edited
Loading

This change will be also made at the Veneer Toolkit level at next code-generation round. While we wait for that we go ahead and override the endpoint.

For reference: pubsub-experimental.googleapis.com stopped working today with the following error:

com.google.cloud.pubsub.PubSubException: io.grpc.StatusRuntimeException: PERMISSION_DENIED: Google Cloud Pub/Sub API (Experimental) has not been used in project google.com:gcloud-devel before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/pubsub-experimental.googleapis.com/overview?project=gcloud-devel then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

See this comment and this StackOverflow question.

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label Aug 10, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2016
@coveralls
Copy link

coveralls commented Aug 10, 2016

Coverage Status

Coverage decreased (-0.009%) to 85.864% when pulling 8959fec on mziccard:fix-pubsub-endpoint into 0637c80 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

mziccard commented Aug 10, 2016

Please @lesv can you have a look at this?

@mziccard
Copy link
Contributor Author

mziccard commented Aug 10, 2016

@garrettjonesgoogle would you also mind having a quick look?

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Aug 10, 2016

Why not just edit the line in PublisherSettings & SubscriberSettings with the default host?

@mziccard
Copy link
Contributor Author

mziccard commented Aug 10, 2016

Why not just edit the line in PublisherSettings & SubscriberSettings with the default host?

This way we also support setting other hosts using the host() setter in the option builder (even though it should not be needed). And I wanted to avoid conflicts with the autogen code.

shinfan
shinfan reviewed Aug 10, 2016
View reviewed changes
gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/spi/DefaultPubSubRpc.java
.provideCredentialsWith(
credentials.createScoped(PublisherSettings.DEFAULT_SERVICE_SCOPES))
.build();
ConnectionSettings subConnectionSettings = ConnectionSettings.newBuilder()

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Aug 10, 2016

Why not just edit the line in PublisherSettings & SubscriberSettings with the default host?

This way we also support setting other hosts using the host() setter in the option builder (even though it should not be needed). And I wanted to avoid conflicts with the autogen code.

Ok it makes sense to plumb through the host from the options. But, my preference would be for PubSubOptions.DEFAULT_HOST to be set to PublisherSettings.DEFAULT_SERVICE_ADDRESS.

If you simply edit the DEFAULT_SERVICE_ADDRESS value e.g. at https://github.com/GoogleCloudPlatform/gcloud-java/blob/master/gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherSettings.java#L112 , then it should match what the generator will output in the next generation, and there won't be a conflict.

That said, it's not a strong opinion, and we can edit the veneer code when we generate next time.

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Aug 10, 2016
Closed
@aozarov aozarov merged commit b25c462 into googleapis:master Aug 10, 2016
@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Aug 10, 2016

LGTM since this issue needs to be fixed urgently

@teddziuba
Copy link

teddziuba commented Aug 11, 2016

Confirmed this fixes #1150. I hand built 0.2.7-SNAPSHOT and deployed it in my app. Looking forward to the next release.

This was referenced Aug 11, 2016
Closed
Merged
@trentonstrong
Copy link

trentonstrong commented Aug 12, 2016 •
edited
Loading

Thanks for fixing this so quickly! Appreciate it.

@mziccard mziccard mentioned this pull request Oct 24, 2016
Closed
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@gcf-owl-bot
docs: Specify limit for properties in Index message in Datastore …
00a696d 
…Admin API (#1149)

* docs: Specify limit for `properties` in `Index` message in Datastore Admin API
docs: Minor formatting in Datastore Admin API

PiperOrigin-RevId: 551819875

Source-Link: googleapis/googleapis@3db8b01

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7ebf1137639b93613e6a6206654a5ba8f21e9321
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2ViZjExMzc2MzliOTM2MTNlNmE2MjA2NjU0YTViYThmMjFlOTMyMSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@release-please
chore(main): release 2.16.3 (#1155)
5fe575a 
🤖 I have created a release *beep* *boop*
---


## [2.16.3](https://togithub.com/googleapis/java-datastore/compare/v2.16.2...v2.16.3) (2023-08-02)


### Documentation

* Specify limit for `properties` in `Index` message in Datastore Admin API ([#1149](https://togithub.com/googleapis/java-datastore/issues/1149)) ([00a696d](https://togithub.com/googleapis/java-datastore/commit/00a696d5e0fe2ffe6c9e02abd902d1b533265310))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.14.0 ([#1159](https://togithub.com/googleapis/java-datastore/issues/1159)) ([fcf07d4](https://togithub.com/googleapis/java-datastore/commit/fcf07d4b5b1f949f1d6b46861406cef88a9a052b))
* Update dependency com.google.errorprone:error_prone_core to v2.21.0 ([#1158](https://togithub.com/googleapis/java-datastore/issues/1158)) ([08dbb3a](https://togithub.com/googleapis/java-datastore/commit/08dbb3ab98870f74b78caa7d160271fccc134ae9))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mziccard @coveralls @garrettjonesgoogle @teddziuba @trentonstrong @shinfan @googlebot @aozarov