bigquery examples: update snippets to use preferred form of delete(). (#5220)

shollyman · web-flow · commit feb3f6fdca2b · 2019-05-24T21:31:36.000+01:00
* bigquery examples: update snippets to use preferred form of delete().
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java
@@ -207,7 +207,8 @@ public boolean deleteDatasetFromId(String projectId, String datasetName) {
   // [VARIABLE "my_table_name"]
   public boolean deleteTable(String datasetName, String tableName) {
     // [START ]
-    boolean deleted = bigquery.delete(datasetName, tableName);
+    TableId tableId = TableId.of(datasetName, tableName);
+    boolean deleted = bigquery.delete(tableId);
     if (deleted) {
       // the table was deleted
     } else {
diff --git a/google-cloud-examples/src/test/java/com/google/cloud/examples/bigquery/snippets/ITDatasetSnippets.java b/google-cloud-examples/src/test/java/com/google/cloud/examples/bigquery/snippets/ITDatasetSnippets.java
@@ -31,6 +31,7 @@
 import com.google.cloud.bigquery.Field;
 import com.google.cloud.bigquery.StandardTableDefinition;
 import com.google.cloud.bigquery.Table;
+import com.google.cloud.bigquery.TableId;
 import com.google.cloud.bigquery.testing.RemoteBigQueryHelper;
 import java.util.Iterator;
 import org.junit.AfterClass;
@@ -128,7 +129,7 @@ public void testListTablesNotEmpty() {
     assertEquals(expectedTableName, actualTable.getTableId().getTable());
     assertFalse(iterator.hasNext());
 
-    bigquery.delete(DATASET, expectedTableName);
+    bigquery.delete(TableId.of(DATASET, expectedTableName));
   }
 
   @Test
@@ -141,7 +142,7 @@ public void testGetTable() {
     assertNotNull(actualTable);
     assertEquals(expectedTableName, actualTable.getTableId().getTable());
 
-    bigquery.delete(DATASET, expectedTableName);
+    bigquery.delete(TableId.of(DATASET, expectedTableName));
   }
 
   @Test
@@ -157,6 +158,6 @@ public void testCreateTable() {
     Field actualField = actualTable.getDefinition().getSchema().getFields().get(0);
     assertEquals(expectedFieldName, actualField.getName());
 
-    bigquery.delete(DATASET, expectedTableName);
+    bigquery.delete(TableId.of(DATASET, expectedTableName));
   }
 }
