Add missing override annotation and serialVersionUID

mziccard · mziccard · commit fbcbfb4a203c · 2016-02-04T10:06:43.000+01:00
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/Acl.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/Acl.java
@@ -325,6 +325,8 @@ Access toPb() {
    */
   public static final class View extends Entity {
 
+    private static final long serialVersionUID = -6851072781269419383L;
+
     private final TableId id;
 
     /**
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/BigQueryImpl.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/BigQueryImpl.java
@@ -621,6 +621,7 @@ private static QueryResult.Builder transformQueryResults(JobId jobId, List<Table
         .results(transformTableData(rowsPb));
   }
 
+  @Override
   public TableDataWriteChannel writer(WriteChannelConfiguration writeChannelConfiguration) {
     return new TableDataWriteChannel(options(),
         writeChannelConfiguration.setProjectId(options().projectId()));
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/CopyJobConfiguration.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/CopyJobConfiguration.java
@@ -204,6 +204,7 @@ public TableId apply(TableId tableId) {
     return builder.build();
   }
 
+  @Override
   com.google.api.services.bigquery.model.JobConfiguration toPb() {
     JobConfigurationTableCopy configurationPb = new JobConfigurationTableCopy();
     configurationPb.setDestinationTable(destinationTable.toPb());
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/ExtractJobConfiguration.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/ExtractJobConfiguration.java
@@ -225,6 +225,7 @@ ExtractJobConfiguration setProjectId(String projectId) {
     return toBuilder().sourceTable(sourceTable().setProjectId(projectId)).build();
   }
 
+  @Override
   com.google.api.services.bigquery.model.JobConfiguration toPb() {
     JobConfigurationExtract extractConfigurationPb = new JobConfigurationExtract();
     extractConfigurationPb.setDestinationUris(destinationUris);
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/LoadJobConfiguration.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/LoadJobConfiguration.java
@@ -282,6 +282,7 @@ LoadJobConfiguration setProjectId(String projectId) {
     return toBuilder().destinationTable(destinationTable().setProjectId(projectId)).build();
   }
 
+  @Override
   com.google.api.services.bigquery.model.JobConfiguration toPb() {
     JobConfigurationLoad loadConfigurationPb = new JobConfigurationLoad();
     loadConfigurationPb.setDestinationTable(destinationTable.toPb());
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/QueryJobConfiguration.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/QueryJobConfiguration.java
@@ -472,6 +472,7 @@ QueryJobConfiguration setProjectId(String projectId) {
     return builder.build();
   }
 
+  @Override
   com.google.api.services.bigquery.model.JobConfiguration toPb() {
     com.google.api.services.bigquery.model.JobConfiguration configurationPb =
         new com.google.api.services.bigquery.model.JobConfiguration();
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableDataWriteChannel.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/TableDataWriteChannel.java
@@ -53,6 +53,7 @@ public void run() {
     }
   }
 
+  @Override
   protected StateImpl.Builder stateBuilder() {
     return StateImpl.builder(options(), entity(), uploadId());
   }
diff --git a/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/WriteChannelConfiguration.java b/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/WriteChannelConfiguration.java
@@ -155,6 +155,7 @@ public Builder projectionFields(List<String> projectionFields) {
       return this;
     }
 
+    @Override
     public WriteChannelConfiguration build() {
       return new WriteChannelConfiguration(this);
     }

Original file line number	Diff line number	Diff line change
`@@ -621,6 +621,7 @@ private static QueryResult.Builder transformQueryResults(JobId jobId, List<Table`
`621`	`621`	`.results(transformTableData(rowsPb));`
`622`	`622`	`}`
`623`	`623`
	`624`	`+ @Override`
`624`	`625`	`public TableDataWriteChannel writer(WriteChannelConfiguration writeChannelConfiguration) {`
`625`	`626`	`return new TableDataWriteChannel(options(),`
`626`	`627`	`writeChannelConfiguration.setProjectId(options().projectId()));`
Original file line number	Diff line number	Diff line change
`@@ -204,6 +204,7 @@ public TableId apply(TableId tableId) {`
`204`	`204`	`return builder.build();`
`205`	`205`	`}`
`206`	`206`
	`207`	`+ @Override`
`207`	`208`	`com.google.api.services.bigquery.model.JobConfiguration toPb() {`
`208`	`209`	`JobConfigurationTableCopy configurationPb = new JobConfigurationTableCopy();`
`209`	`210`	`configurationPb.setDestinationTable(destinationTable.toPb());`
Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,7 @@ ExtractJobConfiguration setProjectId(String projectId) {`
`225`	`225`	`return toBuilder().sourceTable(sourceTable().setProjectId(projectId)).build();`
`226`	`226`	`}`
`227`	`227`
	`228`	`+ @Override`
`228`	`229`	`com.google.api.services.bigquery.model.JobConfiguration toPb() {`
`229`	`230`	`JobConfigurationExtract extractConfigurationPb = new JobConfigurationExtract();`
`230`	`231`	`extractConfigurationPb.setDestinationUris(destinationUris);`
Original file line number	Diff line number	Diff line change
`@@ -282,6 +282,7 @@ LoadJobConfiguration setProjectId(String projectId) {`
`282`	`282`	`return toBuilder().destinationTable(destinationTable().setProjectId(projectId)).build();`
`283`	`283`	`}`
`284`	`284`
	`285`	`+ @Override`
`285`	`286`	`com.google.api.services.bigquery.model.JobConfiguration toPb() {`
`286`	`287`	`JobConfigurationLoad loadConfigurationPb = new JobConfigurationLoad();`
`287`	`288`	`loadConfigurationPb.setDestinationTable(destinationTable.toPb());`
Original file line number	Diff line number	Diff line change
`@@ -472,6 +472,7 @@ QueryJobConfiguration setProjectId(String projectId) {`
`472`	`472`	`return builder.build();`
`473`	`473`	`}`
`474`	`474`
	`475`	`+ @Override`
`475`	`476`	`com.google.api.services.bigquery.model.JobConfiguration toPb() {`
`476`	`477`	`com.google.api.services.bigquery.model.JobConfiguration configurationPb =`
`477`	`478`	`new com.google.api.services.bigquery.model.JobConfiguration();`
Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ public void run() {`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
	`56`	`+ @Override`
`56`	`57`	`protected StateImpl.Builder stateBuilder() {`
`57`	`58`	`return StateImpl.builder(options(), entity(), uploadId());`
`58`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,7 @@ public Builder projectionFields(List<String> projectionFields) {`
`155`	`155`	`return this;`
`156`	`156`	`}`
`157`	`157`
	`158`	`+ @Override`
`158`	`159`	`public WriteChannelConfiguration build() {`
`159`	`160`	`return new WriteChannelConfiguration(this);`
`160`	`161`	`}`