---

Ajay Kannan · Ajay Kannan · commit faaaee052377 · 2015-10-09T14:06:38.000-07:00
yaml --- r: 6257 b: refs/heads/tswast-patch-1 c: eac140a h: refs/heads/master i: 6255: 3d1444c
diff --git a/[refs] b/[refs]
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
 refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
 refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
 refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
-refs/heads/tswast-patch-1: 89dafeafc8625058c697e03995c087831c8929fd
+refs/heads/tswast-patch-1: eac140ad429179cfef8d90a34cf6d429b7e80983
 refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b
diff --git a/branches/tswast-patch-1/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java b/branches/tswast-patch-1/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java
@@ -22,7 +22,6 @@
 import static java.nio.charset.StandardCharsets.UTF_8;
 
 import com.google.api.client.extensions.appengine.http.UrlFetchTransport;
-import com.google.api.client.http.HttpRequest;
 import com.google.api.client.http.HttpRequestInitializer;
 import com.google.api.client.http.HttpTransport;
 import com.google.api.client.http.javanet.NetHttpTransport;
@@ -61,8 +60,6 @@ public abstract class ServiceOptions<
   private final AuthCredentials authCredentials;
   private final RetryParams retryParams;
   private final ServiceRpcFactory<ServiceRpcT, OptionsT> serviceRpcFactory;
-  private final int connectTimeout;
-  private final int readTimeout;
 
   public interface HttpTransportFactory extends Serializable {
     HttpTransport create();
@@ -105,8 +102,6 @@ protected abstract static class Builder<
     private AuthCredentials authCredentials;
     private RetryParams retryParams;
     private ServiceRpcFactory<ServiceRpcT, OptionsT> serviceRpcFactory;
-    private int connectTimeout = -1;
-    private int readTimeout = -1;
 
     protected Builder() {}
 
@@ -126,89 +121,35 @@ protected B self() {
       return (B) this;
     }
 
-    /**
-     * Sets project id.
-     *
-     * @return the builder.
-     */
     public B projectId(String projectId) {
       this.projectId = projectId;
       return self();
     }
 
-    /**
-     * Sets service host.
-     *
-     * @return the builder.
-     */
     public B host(String host) {
       this.host = host;
       return self();
     }
 
-    /**
-     * Sets the transport factory.
-     *
-     * @return the builder.
-     */
     public B httpTransportFactory(HttpTransportFactory httpTransportFactory) {
       this.httpTransportFactory = httpTransportFactory;
       return self();
     }
 
-    /**
-     * Sets the service authentication credentials.
-     *
-     * @return the builder.
-     */
     public B authCredentials(AuthCredentials authCredentials) {
       this.authCredentials = authCredentials;
       return self();
     }
 
-    /**
-     * Sets configuration parameters for request retries.
-     *
-     * @return the builder.
-     */
     public B retryParams(RetryParams retryParams) {
       this.retryParams = retryParams;
       return self();
     }
 
-    /**
-     * Sets the factory for rpc services.
-     *
-     * @return the builder
-     */
     public B serviceRpcFactory(ServiceRpcFactory<ServiceRpcT, OptionsT> serviceRpcFactory) {
       this.serviceRpcFactory = serviceRpcFactory;
       return self();
     }
-
-    /**
-     * Sets the timeout in milliseconds to establish a connection.
-     *
-     * @param connectTimeout connection timeout in milliseconds. 0 for an infinite timeout, a
-     * negative number for the default value (20000).
-     * @return the builder.
-     */
-    public B connectTimeout(int connectTimeout) {
-      this.connectTimeout = connectTimeout;
-      return self();
-    }
-
-    /**
-     * Sets the timeout in milliseconds to read data from an established connection.
-     *
-     * @param readTimeout read timeout in milliseconds. 0 for an infinite timeout, a
-     * negative number for the default value (20000).
-     * @return the builder.
-     */
-    public B readTimeout(int readTimeout) {
-      this.readTimeout = readTimeout;
-      return self();
-    }
   }
 
   protected ServiceOptions(Builder<ServiceRpcT, OptionsT, ?> builder) {
@@ -219,8 +160,6 @@ protected ServiceOptions(Builder<ServiceRpcT, OptionsT, ?> builder) {
     authCredentials = firstNonNull(builder.authCredentials, defaultAuthCredentials());
     retryParams = builder.retryParams;
     serviceRpcFactory = builder.serviceRpcFactory;
-    connectTimeout = builder.connectTimeout;
-    readTimeout = builder.readTimeout;
   }
 
   private static AuthCredentials defaultAuthCredentials() {
@@ -338,84 +277,33 @@ protected static String getAppEngineProjectId() {
 
   protected abstract Set<String> scopes();
 
-  /**
-   * Returns the project id. 
-   */
   public String projectId() {
     return projectId;
   }
 
-  /**
-   * Returns the service host.
-   */
   public String host() {
     return host;
   }
 
-  /**
-   * Returns the transport factory.
-   */
   public HttpTransportFactory httpTransportFactory() {
     return httpTransportFactory;
   }
 
-  /**
-   * Returns the authentication credentials.
-   */
   public AuthCredentials authCredentials() {
     return authCredentials;
   }
 
-  /**
-   * Returns configuration parameters for request retries.
-   */
   public RetryParams retryParams() {
     return retryParams != null ? retryParams : RetryParams.noRetries();
   }
 
-  /**
-   * Returns the factory for rpc services.
-   */
   public ServiceRpcFactory<ServiceRpcT, OptionsT> serviceRpcFactory() {
     return serviceRpcFactory;
   }
 
-  /**
-   * Returns a request initializer responsible for initializing requests according to service
-   * options.
-   */
   public HttpRequestInitializer httpRequestInitializer() {
     HttpTransport httpTransport = httpTransportFactory.create();
-    final HttpRequestInitializer baseRequestInitializer =
-        authCredentials().httpRequestInitializer(httpTransport, scopes());
-    return new HttpRequestInitializer() {
-      @Override
-      public void initialize(HttpRequest httpRequest) throws IOException {
-        baseRequestInitializer.initialize(httpRequest);
-        if (connectTimeout >= 0) {
-          httpRequest.setConnectTimeout(connectTimeout);
-        }
-        if (readTimeout >= 0) {
-          httpRequest.setReadTimeout(readTimeout);
-        }
-      }
-    };
-  }
-
-  /**
-   * Returns the timeout in milliseconds to establish a connection. 0 is an infinite timeout, a
-   * negative number is the default value (20000).
-   */
-  public int connectTimeout() {
-    return connectTimeout;
-  }
-
-  /**
-   * Returns the timeout in milliseconds to read from an established connection. 0 is an infinite
-   * timeout, a negative number is the default value (20000).
-   */
-  public int readTimeout() {
-    return readTimeout;
+    return authCredentials().httpRequestInitializer(httpTransport, scopes());
   }
 
   protected int baseHashCode() {
diff --git a/branches/tswast-patch-1/gcloud-java-examples/README.md b/branches/tswast-patch-1/gcloud-java-examples/README.md
@@ -20,6 +20,33 @@ Add this to your pom.xml file
 </dependency>
 ```
 
+To run examples from your command line:
+
+1. Login using gcloud SDK (`gcloud auth login` in command line)
+
+2. Compile using Maven (`mvn compile` in command line from your base project directory)
+
+3. Run an example using Maven from command line.
+
+  Here's an example run of `DatastoreExample`.
+  
+  Note that you have to enable the Google Cloud Datastore API on the [Google Developers Console][developers-console] before running the following commands.
+  ```
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.DatastoreExample" -Dexec.args="[<project_id>] [user] add my\ comment"
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.DatastoreExample" -Dexec.args="[<project_id>] [user] display"
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.DatastoreExample" -Dexec.args="[<project_id>] [user] delete"
+  ```
+
+  Here's an example run of `StorageExample`.
+
+  Before running the example, go to the [Google Developers Console][developers-console] to ensure that Google Cloud Storage API is enabled and that you have a bucket.  Also ensure that you have a test file (`test.txt` is chosen here) to upload to Cloud Storage stored locally on your machine.
+  ```
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.StorageExample" -Dexec.args="<project_id> upload /path/to/test.txt <bucket_name>"
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.StorageExample" -Dexec.args="<project_id> list <bucket_name>"
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.StorageExample" -Dexec.args="<project_id> download <bucket_name> test.txt"
+  $mvn exec:java -Dexec.mainClass="com.google.gcloud.examples.StorageExample" -Dexec.args="<project_id> delete <bucket_name> test.txt"
+```
+
 Contributing
 ------------
 
@@ -50,3 +77,4 @@ Apache 2.0 - See [LICENSE] for more information.
 [CONTRIBUTING]:https://github.com/GoogleCloudPlatform/gcloud-java/blob/master/CONTRIBUTING.md
 [LICENSE]: https://github.com/GoogleCloudPlatform/gcloud-java/blob/master/LICENSE
 [cloud-platform]: https://cloud.google.com/
+[developers-console]:https://console.developers.google.com/
diff --git a/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java b/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java
@@ -632,15 +632,9 @@ public static Builder builder() {
    * is only valid within a certain time period.
    * This is particularly useful if you don't want publicly
    * accessible blobs, but don't want to require users to explicitly log in.
-   * <p>
-   * Example usage of creating a signed URL that is valid for 2 weeks:
-   * <pre>   {@code
-   *     service.signUrl(BlobInfo.of("bucket", "name"), TimeUnit.DAYS.toSeconds(14));
-   * }</pre>
    *
    * @param blobInfo the blob associated with the signed url
    * @param  expirationTimeInSeconds the signed URL expiration (using epoch time)
-   * @param options optional URL signing options
    * @see <a href="https://cloud.google.com/storage/docs/access-control#Signed-URLs">Signed-URLs</a>
    */
   URL signUrl(BlobInfo blobInfo, long expirationTimeInSeconds, SignUrlOption... options);
diff --git a/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/storage/testing/RemoteGcsHelper.java b/branches/tswast-patch-1/gcloud-java-storage/src/main/java/com/google/gcloud/storage/testing/RemoteGcsHelper.java
@@ -133,8 +133,6 @@ public static RemoteGcsHelper create(String projectId, String keyPath, Option...
               .totalRetryPeriodMillis(120000)
               .initialRetryDelayMillis(250)
               .build())
-          .connectTimeout(60000)
-          .readTimeout(60000)
           .build();
       return new RemoteGcsHelper(storageOptions);
     } catch (FileNotFoundException ex) {
