Skip to content

Commit f766ebc

Browse files
author
Ajay Kannan
committed
---
yaml --- r: 2309 b: refs/heads/update-datastore c: a30b948 h: refs/heads/master i: 2307: ed591f9
1 parent 7e3fd38 commit f766ebc

2 files changed

Lines changed: 33 additions & 12 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ refs/heads/gh-pages: 4e0561bb4504bf647db669a14417b2b2c87ba45d
55
refs/heads/bigquery: 762fa5830e6c398c0396177e3e7fd243bd62cfc3
66
refs/heads/pubsub-alpha: 1a0e970f265af871e02274085b9662b3fe29058b
77
refs/heads/resource-manager: ebf4adc5ee835cd2086c4ac5b4e78d01a5a005a7
8-
refs/heads/update-datastore: de1ce7fe771306435c5cc9c63376fbbdad538ee7
8+
refs/heads/update-datastore: a30b948a2acfbece1aa6fd9924265564d0d910b0
99
refs/tags/0.0.9: 22f1839238f66c39e67ed4dfdcd273b1ae2e8444
1010
refs/tags/v0.0.10: 207ebd2a3472fddee69fe1298eb90429e3306efd
1111
refs/tags/v0.0.11: ffbfba48a6426ff63c08ff2117e58681f251fbf2

branches/update-datastore/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java

Lines changed: 32 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,33 @@ public void testGetArrayNoDeferredResults() {
553553
}
554554

555555
public void testGetArrayDeferredResults() throws DatastoreRpcException {
556+
Set<Key> requestedKeys = new HashSet<Key>();
557+
requestedKeys.add(KEY1);
558+
requestedKeys.add(KEY2);
559+
requestedKeys.add(KEY3);
560+
requestedKeys.add(KEY4);
561+
requestedKeys.add(KEY5);
562+
Iterator<Entity> iter =
563+
createMockDatastoreForDeferredLookup().get(KEY1, KEY2, KEY3, KEY4, KEY5);
564+
Set<Key> keysOfFoundEntities = new HashSet<Key>();
565+
while (iter.hasNext()) {
566+
keysOfFoundEntities.add(iter.next().key());
567+
}
568+
assertEquals(requestedKeys, keysOfFoundEntities);
569+
}
570+
571+
public void testFetchArrayDeferredResults() throws DatastoreRpcException {
572+
List<Entity> foundEntities =
573+
createMockDatastoreForDeferredLookup().fetch(KEY1, KEY2, KEY3, KEY4, KEY5);
574+
assertEquals(foundEntities.get(0).key(), KEY1);
575+
assertEquals(foundEntities.get(1).key(), KEY2);
576+
assertEquals(foundEntities.get(2).key(), KEY3);
577+
assertEquals(foundEntities.get(3).key(), KEY4);
578+
assertEquals(foundEntities.get(4).key(), KEY5);
579+
assertEquals(foundEntities.size(), 5);
580+
}
581+
582+
private Datastore createMockDatastoreForDeferredLookup() throws DatastoreRpcException {
556583
List<DatastoreV1.Key> keysPb = new ArrayList<>();
557584
keysPb.add(KEY1.toPb());
558585
keysPb.add(KEY2.toPb());
@@ -575,15 +602,15 @@ public void testGetArrayDeferredResults() throws DatastoreRpcException {
575602
DatastoreV1.LookupResponse.newBuilder()
576603
.addFound(EntityResult.newBuilder().setEntity(ENTITY1.toPb()))
577604
.addFound(EntityResult.newBuilder().setEntity(entity4.toPb()))
578-
.addDeferred(KEY2.toPb())
579-
.addDeferred(KEY3.toPb())
580-
.addDeferred(KEY5.toPb())
605+
.addDeferred(keysPb.get(2))
606+
.addDeferred(keysPb.get(3))
607+
.addDeferred(keysPb.get(5))
581608
.build());
582609
lookupResponses.add(
583610
DatastoreV1.LookupResponse.newBuilder()
584611
.addFound(EntityResult.newBuilder().setEntity(ENTITY3.toPb()))
585612
.addFound(EntityResult.newBuilder().setEntity(entity4.toPb()))
586-
.addDeferred(KEY5.toPb())
613+
.addDeferred(keysPb.get(5))
587614
.build());
588615
lookupResponses.add(
589616
DatastoreV1.LookupResponse.newBuilder()
@@ -602,13 +629,7 @@ public void testGetArrayDeferredResults() throws DatastoreRpcException {
602629
.retryParams(RetryParams.getDefaultInstance())
603630
.serviceRpcFactory(rpcFactoryMock)
604631
.build();
605-
Datastore datastore = DatastoreFactory.instance().get(options);
606-
Iterator<Entity> iter = datastore.get(KEY1, KEY2, KEY3, KEY4, KEY5);
607-
Set<Entity> foundEntities = new HashSet<>();
608-
while (iter.hasNext()) {
609-
foundEntities.add(iter.next());
610-
}
611-
assertEquals(foundEntities.size(), 5);
632+
return DatastoreFactory.instance().get(options);
612633
}
613634

614635
@Test

0 commit comments

Comments
 (0)